Merge pull request #13 from truework/content-length-check

v1.2.0

.gitignore

@@ -1,5 +1,6 @@
 dist
 .rpt2_cache/
 .rts2_cache_cjs/
+.rts2_cache_js/
 .rts2_cache_es/
 .rts2_cache_umd/

index.ts

@@ -125,10 +125,7 @@ export function gretch<T = DefaultGretchResponse, A = DefaultGretchError>(
         response = (await sent).clone();
         status = response.status || 500;
 
-        if (
-          status !== 204 &&
-          parseInt(response.headers.get("Content-Length")) > 0
-        ) {
+        if (status !== 204) {
           resolved = await response.clone()[key]();
         }
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "gretchen",
-  "version": "1.1.2",
+  "version": "1.2.0-0",
   "description": "Making fetch happen in Typescript.",
   "source": "index.ts",
   "main": "dist/gretchen.js",
@@ -58,7 +58,7 @@
     "husky": "^4.2.3",
     "microbundle": "^0.11.0",
     "node-fetch": "^2.6.0",
-    "np": "^6.2.2",
+    "np": "^6.2.3",
     "prettier": "^1.19.1",
     "pretty-quick": "^2.0.1",
     "ts-node": "^8.4.1"

tests/index.test.ts

@@ -205,7 +205,7 @@ test("returns data as error", async t => {
 test(`body exists, will fail to parse non-json`, async t => {
   const server = createServer((req, res) => {
     res.writeHead(200, {
-      "Content-Length": "3"
+      "Content-Type": "application/json"
     });
     res.end("hey");
   });
@@ -228,14 +228,9 @@ test(`body exists, will fail to parse non-json`, async t => {
   });
 });
 
-/**
- * Ccalling writeHead overrides default Content-Length
- * set by res.end(), i.e. if we removed writeHead here
- * this test would break.
- */
-test(`won't parse body if Content-Length header doesn't exist`, async t => {
+test(`won't parse body if 204 and json()`, async t => {
   const server = createServer((req, res) => {
-    res.writeHead(200, {
+    res.writeHead(204, {
       "Content-Type": "application/json"
     });
     res.end(JSON.stringify({ foo: true }));
@@ -258,32 +253,6 @@ test(`won't parse body if Content-Length header doesn't exist`, async t => {
   });
 });
 
-test(`body does not exist, will not fail to parse non-json`, async t => {
-  const server = createServer((req, res) => {
-    res.writeHead(200);
-    res.end();
-  });
-
-  await new Promise(r => {
-    server.listen(async () => {
-      // @ts-ignore
-      const { port } = server.address();
-
-      const res = await gretch(`http://127.0.0.1:${port}`).json();
-
-      if (res.error) {
-        t.fail();
-      }
-
-      t.pass();
-
-      server.close();
-
-      r();
-    });
-  });
-});
-
 test(`hooks`, async t => {
   const server = createServer((req, res) => {
     res.writeHead(200);