NAS-124189 / 24.04 / Add '-u' - nomount flag for zfs set #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds '-u' flag for zfs set operation. With this flag, mountpoint, sharenfs and sharesmb properties can be updated without actually mounting or sharing the dataset. Previously, if dataset was unmounted, and mountpoint property was updated, dataset was not mounted after the update. This behavior is changed in openzfs#15240. We mount the dataset whenever mountpoint property is updated, regardless if it's mounted or not. To provide the user with option to keep the dataset unmounted and still update the mountpoint without mounting the dataset, '-u' flag can be used. If any of mountpoint, sharenfs or sharesmb properties are updated with '-u' flag, the property is set to desired value but the operation to (re/un)mount and/or (re/un)share the dataset is not performed and dataset remains as it was before. Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Umer Saleem <[email protected]> Closes openzfs#15322
bugclerk
changed the title
usaleem-ix
changed the title
amotin
approved these changes
Oct 3, 2023
|
Not updating JIRA ticket https://ixsystems.atlassian.net/browse/NAS-124189 target versions as no JIRA version corresponds to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Behavior of mountpoint property was updated previously such that, whenever mountpoint
property is updated, it attempts to mount and share the dataset. To provide the user
with option to keep the dataset unmounted and still update the mountpoint without
mounting or sharing the dataset, '-u' flag can be used.
Description
This commit adds '-u' flag for zfs set operation. With this flag, mountpoint, sharenfs
and sharesmb properties can be updated without actually mounting or sharing
the dataset.
If any of mountpoint, sharenfs or sharesmb properties are updated with '-u' flag,
the property is set to desired value but the operation to (re/un)mount and/or
(re/un)share the dataset is not performed and dataset remains as it was before.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.