Ignore error while trying to enable smb share

Signed-off-by: Umer Saleem <[email protected]>

lib/libzfs/libzfs_mount.c

@@ -738,10 +738,23 @@ zfs_share(zfs_handle_t *zhp, const enum sa_protocol *proto)
 		err = sa_enable_share(zfs_get_name(zhp), mountpoint, shareopts,
 		    *curr_proto);
 		if (err != SA_OK) {
-			return (zfs_error_fmt(zhp->zfs_hdl,
-			    proto_table[*curr_proto].p_share_err,
-			    dgettext(TEXT_DOMAIN, "cannot share '%s: %s'"),
-			    zfs_get_name(zhp), sa_errorstr(err)));
+			/*
+			 * For TrueNAS, ignore the error encountered while trying
+			 * to enable the SMB share. We rely on middleware to share
+			 * the filesystem over SMB. Due to difference in user
+			 * shares path, returning the error from here leads to
+			 * pool import failure.
+			 */
+			if (proto_table[*curr_proto].p_prop == ZFS_PROP_SHARESMB)
+				zfs_error_fmt(zhp->zfs_hdl,
+					proto_table[*curr_proto].p_share_err,
+					dgettext(TEXT_DOMAIN, "cannot share '%s: %s'"),
+					zfs_get_name(zhp), sa_errorstr(err));
+			else
+				return (zfs_error_fmt(zhp->zfs_hdl,
+					proto_table[*curr_proto].p_share_err,
+					dgettext(TEXT_DOMAIN, "cannot share '%s: %s'"),
+					zfs_get_name(zhp), sa_errorstr(err)));
 		}
 
 	}