Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic padding for the FullGridCellList #90

Merged
merged 23 commits into from
Jan 29, 2025
Merged

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Dec 23, 2024

Also adds error messages and closes #65, #80.

@efaulhaber efaulhaber added the enhancement New feature or request label Dec 23, 2024
@efaulhaber efaulhaber requested review from LasNikas and svchb December 23, 2024 11:23
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (88925f9) to head (2af4c9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   88.15%   88.69%   +0.54%     
==========================================
  Files          15       15              
  Lines         498      522      +24     
==========================================
+ Hits          439      463      +24     
  Misses         59       59              
Flag Coverage Δ
unit 88.69% <100.00%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber self-assigned this Dec 24, 2024
src/nhs_grid.jl Outdated Show resolved Hide resolved
@efaulhaber efaulhaber requested a review from LasNikas January 7, 2025 16:20
LasNikas
LasNikas previously approved these changes Jan 7, 2025
@efaulhaber efaulhaber requested a review from LasNikas January 23, 2025 10:09
src/cell_lists/full_grid.jl Outdated Show resolved Hide resolved
@efaulhaber efaulhaber requested a review from svchb January 28, 2025 13:24
svchb
svchb previously approved these changes Jan 28, 2025
@svchb svchb dismissed their stale review January 28, 2025 15:34

Failing tests

Copy link
Collaborator

@LasNikas LasNikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efaulhaber efaulhaber merged commit 3522572 into main Jan 29, 2025
12 checks passed
@efaulhaber efaulhaber deleted the ef/automatic-padding branch January 29, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FullGridCellList can't handle NaN values and throws unspecific errors
3 participants