Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: string hover contents not being translated #482

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: string hover contents not being translated #482

merged 1 commit into from
Jan 23, 2025

Conversation

diogotcorreia
Copy link
Member

Fixes #481

@diogotcorreia diogotcorreia added type:bug Something isn't working as expected module:core Related to the core module labels Jan 23, 2025
@diogotcorreia diogotcorreia added this to the 3.11.2 milestone Jan 23, 2025
@diogotcorreia diogotcorreia self-assigned this Jan 23, 2025
@diogotcorreia diogotcorreia merged commit 443359a into v3 Jan 23, 2025
1 check passed
@diogotcorreia diogotcorreia deleted the fix/hover-contents-string branch January 23, 2025 21:27
diogotcorreia added a commit that referenced this pull request Jan 23, 2025
@diogotcorreia
refactor: always set basecomponent[] after translating hover
1205f93 
If String is provided, some formatting like RGB colors might not work
correctly.

See #481
See #482
@diogotcorreia diogotcorreia mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@diogotcorreia diogotcorreia

Labels
module:core Related to the core module type:bug Something isn't working as expected
Projects
Triton
Status: Done
Milestone
3.11.2
Development

Successfully merging this pull request may close these issues.

Hover contents not translated
1 participant
@diogotcorreia