give deflate::State::sym_buf
its own allocation
#27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zlib-ng
implementation overlapspending_buf
andsym_buf
in the same allocation. The end ofpending_buf
will eventually cross over the initial start ofsym_buf
. Hence we can't really make this safe.Giving
sym_buf
its own allocation is a simple solution, and does use more memory. But I think the alternative of some custom abstraction over the combinedpending_buf
/sym_buf
would be very fragile. I think this is the better solution for now.