To add a SAFETY comment to the now function
#811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `unsafe` block should include necessary comments to complete the safety abstraction. In the implementation of the `now` function, necessary `SAFETY` comments should be added to explain its safety, with particular emphasis on the fact that `libc::clock_gettime` initializes the `spec`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
- Coverage 57.32% 57.31% -0.01%
==========================================
Files 74 74
Lines 10505 10505
==========================================
- Hits 6022 6021 -1
- Misses 4483 4484 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks for the contribution! A review will be upcoming :) |
squell
approved these changes
Jan 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Note: there are some CI issues due to an update for clippy; fixing those, I expect this to be mergeable then. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
trifectatechfoundation:main
with commit Jan 8, 2024
2fa9234
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unsafeblock should include necessary comments to complete the safety abstraction.In the implementation of the
nowfunction, necessarySAFETYcomments should be added to explain its safety, with particular emphasis on the fact thatlibc::clock_gettimeinitializes thespec.