Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update self_check function to work with sudo invoked through setuid wrapper #772

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

japaric
Copy link
Collaborator

@japaric japaric commented Sep 20, 2023

thanks @r-vdp for the initial implementation.
co-authored by @rnijveld

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (e2edeca) 55.24% compared to head (691022b) 55.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   55.24%   55.23%   -0.01%     
==========================================
  Files          72       72              
  Lines        9842     9841       -1     
==========================================
- Hits         5437     5436       -1     
  Misses       4405     4405              
Files Changed Coverage Δ
src/common/error.rs 9.80% <0.00%> (ø)
src/sudo/mod.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squell
Copy link
Member

squell commented Sep 20, 2023

Hat tip to @yorickvP for noticing, as well.

@github-actions
Copy link

Number of dependencies and binary size impact report

Metric main PR #772 Delta
Direct dependencies 3 3 -
Total dependencies 4 4 -
Binary size 1021.7 KiB 1021.5 KiB -
Text size 593.5 KiB 593.2 KiB -
Dependencies diff
 └─ sudo-rs [v0.2.0]
    ├─ glob [v0.3.1]
    ├─ libc [v0.2.147]
    └─ log [v0.4.20]

@squell squell enabled auto-merge September 20, 2023 08:04
@squell squell added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 4c177bc Sep 20, 2023
@japaric japaric deleted the self-check branch September 20, 2023 08:40
@r-vdp
Copy link
Contributor

r-vdp commented Sep 20, 2023

Cool, I didn't get the time to make a PR for this patch yet, but glad to see it merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants