visudo-rs: Improve the error message #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` $ visudo-rs Come on... you can do better than that. syntax error: expected parameter syntax error: expected host name What now? e(x)it without saving / (e)dit again: ``` "Come on... you can do better than that." too informal
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
==========================================
+ Coverage 55.24% 55.25% +0.01%
==========================================
Files 72 72
Lines 9840 9840
==========================================
+ Hits 5436 5437 +1
+ Misses 4404 4403 -1
☔ View full report in Codecov by Sentry. |
pvdrz
approved these changes
Sep 19, 2023
|
I did this jokingly and absolutely forgot about it 😅 |
Merged
via the queue into
trifectatechfoundation:main
with commit Sep 19, 2023
d106c4e
15 checks passed
|
@pvdrz no worries, I knew you could do better than this ;) |
|
🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Come on... you can do better than that." is too informal