@trezor/address-validator

[mroz22]

this is far from complete but I'd like to open it anyway.

lets move trezor-address-validator to monorepo.

there is one test failing when in monorepo and passing in standalone repo. I don't get it 😱

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Deprecated	npm/[email protected]	Reason: jsSHA versions < 3.0.0 will no longer receive feature updates	packages/address-validator/package.json	🚫

View full report↗︎

Next steps

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/[email protected]

[mroz22]

ok, finally found what was the problem = strict mode + missing const

now it should work. but I started questioning if it makes much sense to move it into the monorepo

cons:

• touching whats not broken
• touching something that we didn't need to touch for years
• diverging from the upstream more and more

pros:

• when we need to touch it it will be easier to maintain

[mroz22]

@SocketSecurity ignore npm/[email protected]

this alert doesn't seem related to this PR at all

[mroz22]

/rebase

[github-actions]

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/9905960317

[szymonlesisz]

looks legit 👍