Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fees redesign #16577

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fees redesign #16577

wants to merge 1 commit into from

Conversation

enjojoy
Copy link
Contributor

@enjojoy enjojoy commented Jan 23, 2025

Description

Implemented new design for fees

Design

Screenshots:

@jvaclavik
Copy link
Contributor

image

Just a quick note:
This component should be implemented in the design system.

API should be really simple and could looks like this:

type RadioCardProps = {
  isActive: boolean;
  children: React.ReactNode;
}

Usage:

<RadioCard
  isActive={true}
>
  {children}
</RadioCard>  

It should solve only one "card" and you can use Column for creating grid:

<Column gap={...}>
  <RadioCard ... />
  <RadioCard ... />
</Column>

(RadioCard name is probably not final)

@adamhavel
Copy link
Contributor

As @jvaclavik said, I wouldn't make this out of the Card component

@enjojoy
Copy link
Contributor Author

enjojoy commented Jan 24, 2025

@adamhavel I already have this part done locally 🥲 But okay, I'll make the separate component and ask for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants