Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connect-common): sort coins-eth.json by chain_id #16576

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tomasklim
Copy link
Member

@tomasklim tomasklim commented Jan 23, 2025

Description

Related Issue

Resolve #15819

Screenshots:

Copy link
Member

@martykan martykan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"type": "blockbook",
"url": ["https://tbtc1.trezor.io", "https://tbtc2.trezor.io"]
},
"blockchain_link": { "type": "blockbook", "url": ["https://tbtc4-1.trezor.io"] },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! We don't want this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But somebody already updated it in fw repo trezor/trezor-firmware#4486

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can drop it, but it was autogenerated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

392f393 ok let's leave it for Carlos

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rebased, Please approve again,

@tomasklim
Copy link
Member Author

/rebase

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update EVMs info in fw repo
2 participants