Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(trade): move API to the suite-common #16545

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

chore(trade): move API to the suite-common #16545

wants to merge 8 commits into from
+146 −95

Conversation

adderpositive
Copy link
Contributor

@adderpositive adderpositive commented Jan 22, 2025 •
edited
Loading

Description

  • Moving trading API to the suite-common package
  • Creating some necessary types for API
  • Prepare headers for mobile

Related Issue

Resolve #16517

@adderpositive adderpositive added +Invity Related to Invity project code Code improvements labels Jan 22, 2025
@adderpositive adderpositive self-assigned this Jan 22, 2025
@adderpositive adderpositive marked this pull request as ready for review January 23, 2025 10:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 23
  • More info

Learn more about 𝝠 Expo Github Action

@adderpositive adderpositive mentioned this pull request Jan 23, 2025
Merged
vytick
vytick reviewed Jan 23, 2025
View reviewed changes
suite-common/invity/src/invityAPI.ts Outdated Show resolved Hide resolved
suite-common/invity/src/types.ts Outdated Show resolved Hide resolved
@adderpositive adderpositive requested a review from vytick January 24, 2025 12:20
vytick
vytick approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vytick vytick vytick approved these changes

@FreeWall FreeWall Awaiting requested review from FreeWall

@jbazant jbazant Awaiting requested review from jbazant

@tomasklim tomasklim Awaiting requested review from tomasklim

Requested changes must be addressed to merge this pull request.

Assignees

@adderpositive adderpositive

Labels
code Code improvements +Invity Related to Invity project
Projects
Suite Desktop
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move invity api wrapper to suite-common
3 participants
@adderpositive @vytick @tomasklim