@solana/web3.js v2 update #15536
@solana/web3.js v2 update #15536
Conversation
|
🚀 Expo preview is ready!
|
|
I tested desktop app + tor issue, it's not present 👍🏻 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
martykan
added
the
build-desktop
martykan
added
build-desktop
|
@SocketSecurity ignore npm/@solana/[email protected] |
Tested again, it closed with no problems @tomasklim |
martykan
force-pushed
the
solana-web3-js-two-dot-oh
branch
4 times, most recently
from
ff99aee to
ec2125b
Compare
martykan
added
build-desktop
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12081074553 |
|
Rebasing failed, please rebase manually. |
This change attempts to largely replicate the old account and transaction shapes, but also represents a breaking change as some of the old types (like `PublicKey`) no longer exist in `@solana/web3.js` version 2. Some type utilties were added so that we could source the _actual_ data shapes from the API calls themselves. For instance, we choose the return type that results from calling `getTransaction` with the config `"encoding": "jsonParsed"` _in particular_.
1. Added an RPC subscriptions instance to the `API` type
2. Added code to throw in the event that the transaction is a durable nonce transaction. A little extra work would have to be done to import and construct the durable nonce transaction confirmer.
3. Added a `FIXME` explaining why it would be better to save the `lastValidBlockhash` at the time the transaction was first given a blockhash lifetime, instead of fetching a too-new one in `pushTransaction`
4. Eliminated all of the custom transaction confirmation code, in favour of the new built-in routines.
5. Added a `FIXME` to note that the `fetch()` API typically doesn't allow you to override the `Origin` header. I didn't test whether your runtime actually allows it or not.
Note that all RPC methods are now cancellable via `AbortController`, if you supply an `AbortSignal` to the send/subscribe methods (ie. `.send({ abortSignal })`)
tomasklim
force-pushed
the
solana-web3-js-two-dot-oh
branch
from
233b823 to
e7d4b2f
Compare
…ls` to `@solana/web3.js` v2 1. Corrected a decimal amount in one of the fixtures. That `amount` field is denominated in basis points. 2. Deleted most of the custom transaction instruction formatting code, in favour of the new auto-generated program clients for the System, Compute Budget, and Token programs. 3. Added a note that `lastValidBlockHeight` is sometimes `undefined` in tests
tomasklim
force-pushed
the
solana-web3-js-two-dot-oh
branch
from
e7d4b2f to
52c2551
Compare
|
QA OK Info: Suite version: desktop 24.12.0 (ba5174e) |
Description
@solana/web3.jsversion 2.0.0 #15535Resolve #12628
Screenshots: