Upgrade ESLint and all plugis & revalidate the config and ALL of the rules

eslint.config.mjs

@@ -0,0 +1,3 @@
+import { eslint } from '@trezor/eslint';
+
+export default [...eslint];

package.json

@@ -31,7 +31,7 @@
         "type-check": "yarn nx run-many --target=type-check",
         "type-check:force": "rimraf -rf -- **/libDev && yarn type-check",
         "test:unit": "yarn nx run-many --target=test:unit",
-        "lint:js": "eslint . --cache --cache-strategy content --ignore-path .gitignore",
+        "lint:js": "eslint . --cache --cache-strategy content --flag unstable_config_lookup_from_file",
         "lint:styles": "yarn nx run-many --target=lint:styles",
         "lint": "yarn lint:styles && yarn lint:js",
         "lint-staged": "npx lint-staged",
@@ -121,24 +121,15 @@
         "@babel/preset-typescript": "^7.24.7",
         "@babel/runtime": "^7.23.9",
         "@suite-common/wallet-types": "workspace:*",
+        "@trezor/eslint": "workspace:*",
         "@types/jest": "29.5.12",
         "@types/node": "20.12.7",
         "@types/prettier": "^3.0.0",
         "@types/semver": "^7.5.6",
         "@types/tar": "^6.1.11",
-        "@typescript-eslint/eslint-plugin": "^8.8.1",
-        "@typescript-eslint/parser": "^8.8.1",
         "babel-jest": "29.7.0",
         "depcheck": "^1.4.7",
-        "eslint": "^8.57.1",
-        "eslint-plugin-chai-friendly": "^1.0.1",
-        "eslint-plugin-cypress": "^3.5.0",
-        "eslint-plugin-import": "^2.31.0",
-        "eslint-plugin-jest": "^28.8.3",
-        "eslint-plugin-jsx-a11y": "^6.10.0",
-        "eslint-plugin-local-rules": "^3.0.2",
-        "eslint-plugin-react": "^7.37.1",
-        "eslint-plugin-react-hooks": "^4.6.2",
+        "globals": "^15.11.0",
         "jest": "29.7.0",
         "jest-environment-jsdom": "29.7.0",
         "jest-expo": "^50.0.2",

packages/blockchain-link-utils/eslint.config.mjs

@@ -0,0 +1,15 @@
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        rules: {
+            'import/no-extraneous-dependencies': [
+                'error',
+                {
+                    includeTypes: true,
+                },
+            ],
+        },
+    },
+];

packages/blockchain-link-utils/package.json

@@ -28,6 +28,7 @@
     },
     "devDependencies": {
         "@trezor/blockchain-link-types": "workspace:*",
+        "@trezor/eslint": "workspace:*",
         "@trezor/type-utils": "workspace:*",
         "tsx": "^4.16.3"
     },

packages/blockchain-link/eslint.config.mjs

@@ -0,0 +1,12 @@
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        rules: {
+            camelcase: 'off',
+            'no-underscore-dangle': 'off',
+            'no-console': 'warn',
+        },
+    },
+];

packages/blockchain-link/package.json

@@ -65,6 +65,7 @@
     },
     "devDependencies": {
         "@trezor/e2e-utils": "workspace:*",
+        "@trezor/eslint": "workspace:*",
         "@trezor/type-utils": "workspace:*",
         "fs-extra": "^11.2.0",
         "html-webpack-plugin": "^5.6.0",

packages/coinjoin/eslint.config.mjs

@@ -0,0 +1,11 @@
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        rules: {
+            'no-bitwise': 'off',
+            'no-console': 'warn',
+        },
+    },
+];

packages/coinjoin/package.json

@@ -29,6 +29,7 @@
         "@trezor/blockchain-link": "workspace:*",
         "@trezor/blockchain-link-types": "workspace:*",
         "@trezor/blockchain-link-utils": "workspace:*",
+        "@trezor/eslint": "workspace:*",
         "@trezor/utils": "workspace:*",
         "@trezor/utxo-lib": "workspace:*",
         "cross-fetch": "^4.0.0",

packages/components/.storybook/main.js

@@ -1,5 +1,13 @@
 import { dirname, join } from 'path';
 
+/**
+ * This function is used to resolve the absolute path of a package.
+ * It is needed in projects that use Yarn PnP or are set up within a monorepo.
+ */
+function getAbsolutePath(value) {
+    return dirname(require.resolve(join(value, 'package.json')));
+}
+
 module.exports = {
     stories: ['../src/**/*.stories.*'],
     logLevel: 'debug',
@@ -14,18 +22,12 @@ module.exports = {
         name: getAbsolutePath('@storybook/react-webpack5'),
         options: {},
     },
-    babel: async options => {
+    babel: options => {
         options.presets.push('@babel/preset-typescript');
+
         return options;
     },
     features: {
         storyStoreV7: false, // Remove this line when storiesOf is not used anymore
     },
 };
-/**
- * This function is used to resolve the absolute path of a package.
- * It is needed in projects that use Yarn PnP or are set up within a monorepo.
- */
-function getAbsolutePath(value) {
-    return dirname(require.resolve(join(value, 'package.json')));
-}

packages/components/eslint.config.mjs

@@ -0,0 +1,11 @@
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        files: ['**/*.stories.tsx'],
+        rules: {
+            'import/no-default-export': 'off',
+        },
+    },
+];

packages/connect-examples/webextension-mv2/eslint.config.mjs

@@ -0,0 +1,15 @@
+// Todo: figure out the better way, if this would be package, we would use "@trezor/eslint": "workspace:*" in package.json
+import parentConfig from '../../../eslint.config.mjs';
+
+export default [
+    ...parentConfig,
+    {
+        ignores: ['**/vendor*/'],
+    },
+    {
+        rules: {
+            'no-underscore-dangle': 'off',
+            camelcase: 'off',
+        },
+    },
+];

packages/connect-explorer/eslint.config.mjs

@@ -0,0 +1,43 @@
+import * as mdx from 'eslint-plugin-mdx';
+
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        ignores: ['.next/**/*'],
+    },
+
+    // Mdx
+    {
+        ...mdx.flat,
+        rules: {
+            'jsx-a11y/click-events-have-key-events': 'off',
+            'jsx-a11y/no-static-element-interactions': 'off',
+            'import/no-default-export': 'off',
+            'no-console': 'off',
+            'no-restricted-syntax': 'off',
+        },
+    },
+    {
+        files: ['**/*.mdx'],
+        rules: {
+            'react/no-unescaped-entities': 'off',
+        },
+    },
+    {
+        rules: {
+            'no-console': 'off',
+            'import/no-default-export': 'off', // Todo: shall be fixed
+            'no-restricted-syntax': 'off', // Todo: shall be fixed
+            '@typescript-eslint/no-restricted-imports': 'off',
+            '@typescript-eslint/no-shadow': 'off',
+            'react/jsx-filename-extension': [
+                'error',
+                {
+                    extensions: ['.tsx', '.mdx'],
+                },
+            ],
+        },
+    },
+];

packages/connect-explorer/package.json

@@ -48,6 +48,7 @@
         "swr": "^2.2.5"
     },
     "devDependencies": {
+        "@trezor/eslint": "workspace:*",
         "@types/redux-logger": "^3.0.11",
         "babel-plugin-styled-components": "^2.1.4",
         "concurrently": "^8.2.2",

packages/connect-iframe/eslint.config.mjs

@@ -0,0 +1,10 @@
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        rules: {
+            'import/no-default-export': 'off', // Todo: shall be fixed
+        },
+    },
+];

packages/connect-iframe/package.json

@@ -20,6 +20,7 @@
     "devDependencies": {
         "@babel/preset-typescript": "^7.24.7",
         "@trezor/env-utils": "workspace:*",
+        "@trezor/eslint": "workspace:*",
         "babel-loader": "^9.1.3",
         "copy-webpack-plugin": "^12.0.2",
         "es6-promise": "^4.2.8",

packages/connect-plugin-stellar/eslint.config.mjs

@@ -0,0 +1,10 @@
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        rules: {
+            'import/no-default-export': 'off', // Todo: fix and solve
+        },
+    },
+];

packages/connect-plugin-stellar/package.json

@@ -31,7 +31,8 @@
         "tslib": "^2.6.2"
     },
     "devDependencies": {
-        "@stellar/stellar-sdk": "^12.1.3"
+        "@stellar/stellar-sdk": "^12.1.3",
+        "@trezor/eslint": "workspace:*"
     },
     "dependencies": {
         "@trezor/utils": "workspace:*"

packages/connect-popup/e2e/playwright.config.ts

@@ -12,4 +12,6 @@ const config: PlaywrightTestConfig = {
         ...devices[process.env.MOBILE ? 'Pixel 7' : 'Desktop Chrome'],
     },
 };
+
+// eslint-disable-next-line import/no-default-export
 export default config;

packages/connect-popup/e2e/tests/methods.test.ts

@@ -63,6 +63,7 @@ filteredFixtures.forEach(f => {
         // - fixture require different device than prev fixture, or
         // - fixture is retried
         // FIXME: always reset for now, due to flaky tests with bridge bug
+        // eslint-disable-next-line no-constant-binary-expression
         if (true || JSON.stringify(device) !== JSON.stringify(f.device) || retry) {
             device = f.device;
             await TrezorUserEnvLink.stopBridge();

packages/connect-popup/eslint.config.mjs

@@ -0,0 +1,11 @@
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        rules: {
+            'no-console': 'off',
+            'no-restricted-syntax': 'off', // Todo: fix and solve
+        },
+    },
+];

packages/connect-popup/package.json

@@ -36,6 +36,7 @@
         "@playwright/browser-firefox": "^1.46.1",
         "@playwright/browser-webkit": "^1.46.1",
         "@playwright/test": "^1.46.1",
+        "@trezor/eslint": "workspace:*",
         "@trezor/node-utils": "workspace:*",
         "@trezor/trezor-user-env-link": "workspace:*",
         "@trezor/utils": "workspace:*",

packages/connect-web/eslint.config.mjs

@@ -0,0 +1,13 @@
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        rules: {
+            'no-underscore-dangle': 'off', // underscore is used
+            camelcase: 'off', // camelcase is used
+            'jest/valid-expect': 'off', // because of cypress tests
+            'import/no-default-export': 'off', // Todo: shall be fixed
+        },
+    },
+];

packages/connect-web/package.json

@@ -53,6 +53,7 @@
         "@playwright/browser-firefox": "^1.46.1",
         "@playwright/browser-webkit": "^1.46.1",
         "@playwright/test": "^1.46.1",
+        "@trezor/eslint": "workspace:*",
         "@types/chrome": "^0.0.278",
         "@types/w3c-web-usb": "^1.0.10",
         "babel-loader": "^9.1.3",

packages/connect-webextension/eslint.config.mjs

@@ -0,0 +1,10 @@
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        rules: {
+            'no-underscore-dangle': 'off', // underscore is used
+        },
+    },
+];

packages/connect-webextension/package.json

@@ -46,6 +46,7 @@
     },
     "devDependencies": {
         "@babel/preset-typescript": "^7.24.7",
+        "@trezor/eslint": "workspace:*",
         "@trezor/node-utils": "workspace:*",
         "@trezor/trezor-user-env-link": "workspace:*",
         "@types/chrome": "^0.0.278",