chore: enable no-constant-binary-expression as it becames recommanded default in new ESLint #15241
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
requested review from
mroz22,
szymonlesisz and
martykan
as code owners
peter-sanderson
commented
Nov 5, 2024
| @@ -99,7 +99,7 @@ export const Pagination = ({ | |||
| <PageItem | |||
| key={i} | |||
| data-testid={`@wallet/accounts/pagination/${i}`} | |||
| data-test-activated={i === currentPage ?? 'true'} | |||
There was a problem hiding this comment.
I think this is always true|false and never result in 'true' (string).
The ?? works like this:
peter-sanderson
commented
Nov 5, 2024
| @@ -77,8 +77,8 @@ export const PortfolioCard = memo(() => { | |||
| } | |||
|
|
|||
| const isWalletEmpty = !discoveryStatus && isDeviceEmpty; | |||
| const isWalletLoading = discoveryStatus?.status === 'loading' ?? false; | |||
There was a problem hiding this comment.
same here, even if discoveryStatus?.status is undefined, the === 'loading turns it into false and it never fallback to the ??
peter-sanderson
commented
Nov 5, 2024
| @@ -48,7 +48,7 @@ export const CoinmarketBalance = ({ | |||
| }); | |||
|
|
|||
| if (showOnlyAmount) { | |||
| if (!balance ?? isNaN(Number(balance))) return null; | |||
| if (balance === undefined || isNaN(Number(balance))) return null; | |||
There was a problem hiding this comment.
Discussed with @adderpositive
23 tasks
Lemonexe
approved these changes
Nov 5, 2024
peter-sanderson
force-pushed
the
no-constant-binary-expression
branch
from
4153de3
to
54d80c0
Compare
… default in new ESLint
peter-sanderson
force-pushed
the
no-constant-binary-expression
branch
from
54d80c0
to
08c97ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eslint.org/docs/latest/rules/no-constant-binary-expression will became default in recommanded config