-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cardano token definitions fix #13189
Merged
tomasklim
merged 6 commits into
develop
from
feat/cardano-without-token-definitions-4ever
Jul 5, 2024
Merged
Cardano token definitions fix #13189
tomasklim
merged 6 commits into
develop
from
feat/cardano-without-token-definitions-4ever
Jul 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasklim
force-pushed
the
feat/cardano-without-token-definitions-4ever
branch
from
July 4, 2024 11:20
761ba00
to
46ac130
Compare
tomasklim
changed the title
Feat/cardano without token definitions 4ever
Cardano token definitions fix
Jul 4, 2024
tomasklim
added
release
Will be included in the upcoming release. Needs to be backported to the release branch.
build-desktop
This will trigger the build of desktop apps for your PR
labels
Jul 4, 2024
@trezor/qa
|
tomasklim
force-pushed
the
feat/cardano-without-token-definitions-4ever
branch
from
July 4, 2024 11:37
46ac130
to
006302a
Compare
marekrjpolak
reviewed
Jul 4, 2024
marekrjpolak
approved these changes
Jul 4, 2024
work in progress Upgrade from
|
/rebase |
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/9795998811 |
trezor-ci
force-pushed
the
feat/cardano-without-token-definitions-4ever
branch
from
July 4, 2024 14:23
35861a2
to
ab06bcf
Compare
do not merge yet please |
tomasklim
force-pushed
the
feat/cardano-without-token-definitions-4ever
branch
from
July 4, 2024 19:58
ab06bcf
to
67111eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build-desktop
This will trigger the build of desktop apps for your PR
release
Will be included in the upcoming release. Needs to be backported to the release branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve #13169
Screenshots:
if you compare it with #13093 we also have fiat for banker coin! because that one uses unit and not policy id on coingecko 🙃
(token-definitions turned on just for this screenshot)