Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix sldev build where git lfs checkout was missing #12440

Closed
wants to merge 1 commit into from

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented May 16, 2024

@bosomt @STew790 please test if fw update works for you on this branch.

also are we sure that it will work in production builds?

@mroz22 mroz22 marked this pull request as ready for review May 16, 2024 12:50
@mroz22 mroz22 requested a review from vdovhanych as a code owner May 16, 2024 12:50
@vdovhanych
Copy link
Member

This will eat all of the lfs bandwidth for us in a day or so :) That was the reason we got rid of it for this in the first place.

@mroz22
Copy link
Contributor Author

mroz22 commented May 16, 2024

ok in that cases @trezor/qa should be informed 👍

@mroz22
Copy link
Contributor Author

mroz22 commented May 16, 2024

@MiroslavProchazka maybe we can yet again start pulling firmwares for web suite from data.trezor.io.
the only downside for this is that you won't be able to test newly added firmware binaries in suite web on sldev.

  • it would be nice to add some better errors to UI - validate fw binary slightly before sending it into device.

@mroz22 mroz22 marked this pull request as draft May 16, 2024 14:19
@mroz22 mroz22 closed this May 20, 2024
@mroz22 mroz22 deleted the ci/fix-web-build-git-lfs branch June 24, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants