-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suite-native): new device switcher #12300
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore-all |
c2f2504
to
2ea26ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just nitpicks, but what seems strange is the need to type cast devices and optionality of some of the component props.
suite-native/device-manager/src/components/AddHiddenWalletButton.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/AddHiddenWalletButton.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceManagerModal.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceItemContent.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceItemContent.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceItemContent.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/PortfolioTrackerDeviceManagerContent.tsx
Show resolved
Hide resolved
fb7e2fd
to
326abb2
Compare
suite-native/device-manager/src/components/DeviceManagerContent.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceManagerContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
suite-native/device-manager/src/components/DeviceItem/SimpleDeviceItemContent.tsx
Outdated
Show resolved
Hide resolved
5825a46
to
043485d
Compare
suite-native/device-manager/src/components/DeviceManagerContent.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceManagerContent.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceItem/DeviceItemIcon.tsx
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceInfoButton.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceItem/DeviceItem.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceItem/DeviceItem.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DeviceManagerContent.tsx
Outdated
Show resolved
Hide resolved
suite-native/device-manager/src/components/DevicesToggleButton.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANKS FOR RESOLVING ALL OF THE COMMENTS 🎉
Tested on emulator on android and works well with remember and passphrase as well.
Really nice animation, well done.
Next time, it would be better for review and development to split into smaller PR's but maybe it was unexpected to be this big 😮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Thanks for addressing my comments.
@matejkriz Good catch with layout glitch! fixed in a5016a6 |
/rebase |
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/9097132563 |
eb117cf
to
3cdd926
Compare
Update wallet switcher visual to show view only devices correctly
These two tasks will be dealt with in following PR so this one is not even bigger
Related Issue
Part of #11892
Screenshots:
Simulator.Screen.Recording.-.iPhone.15.-.2024-05-07.at.22.15.43.mp4