Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing desktop tests in gha #12087

Merged
merged 1 commit into from
May 20, 2024
Merged

testing desktop tests in gha #12087

merged 1 commit into from
May 20, 2024

Conversation

andrcj
Copy link
Contributor

@andrcj andrcj commented Apr 19, 2024 •
edited
Loading

  • adding desktop PW tests to github actions
  • disabling desktop PW tests in gitlab flow (will remove it completely after some "prod" testing)

Things that need to be solved in follow-up PRs:

  • make tests successfully use node-bridge instead of legacy-bridge
  • adding manual screenshots to artefacts (they are added locally but not in CI)
  • figure out a way to include automated screenshots into desktop PW similar to web one (check here)

@andrcj andrcj added the e2e End-to-end tests builded in CI label Apr 19, 2024
@andrcj andrcj self-assigned this Apr 19, 2024
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch 2 times, most recently from 2ab0649 to 44935bb Compare April 19, 2024 15:55
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from 98a6fef to 1ddc1a1 Compare April 22, 2024 09:01
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from 1ddc1a1 to f147ec7 Compare April 22, 2024 11:49
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch 2 times, most recently from 79349c3 to 1f4ad47 Compare April 22, 2024 12:18
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from 1f4ad47 to 69e0ce7 Compare April 22, 2024 12:52
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from 69e0ce7 to 54bc779 Compare April 22, 2024 13:36
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from 54bc779 to fa51409 Compare April 22, 2024 13:38
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from 3796fc8 to 626ac1d Compare April 22, 2024 15:19
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from b2cddb5 to 592830d Compare May 16, 2024 19:30
@andrcj andrcj marked this pull request as ready for review May 17, 2024 08:07
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from 2bb33d9 to 5ebcdf2 Compare May 17, 2024 08:29
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch 2 times, most recently from 44ecf84 to 95d8120 Compare May 20, 2024 07:48
mroz22
mroz22 reviewed May 20, 2024
View reviewed changes
ci/test.yml Outdated Show resolved Hide resolved
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from c8c810e to ed5a84d Compare May 20, 2024 09:27
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from d878f66 to f173140 Compare May 20, 2024 11:03
mroz22
mroz22 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand why node-bridge is turned off. but ok. please fix

@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from f173140 to fa78f67 Compare May 20, 2024 14:51
@andrcj andrcj force-pushed the chore/moveDesktopTestsToGHA branch from fa78f67 to 5e8f94f Compare May 20, 2024 15:02
@andrcj andrcj merged commit 7d8cd69 into develop May 20, 2024
51 checks passed
@andrcj andrcj deleted the chore/moveDesktopTestsToGHA branch May 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroz22 mroz22 mroz22 approved these changes

@vdovhanych vdovhanych Awaiting requested review from vdovhanych vdovhanych is a code owner

Assignees

@andrcj andrcj

Labels
e2e End-to-end tests builded in CI
Projects
No open projects
Suite Pull Requests
Status: 🗒 Draft
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrcj @mroz22 @vdovhanych