Skip to content

Commit

Permalink
ci(github): fix input syntax in NPM release workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
karliatto committed May 14, 2024
1 parent af19597 commit c25dbe5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release-connect-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_dispatch:
inputs:
packages:
description: "Comma-separated names of the packages to deploy. (example: 'connect,blockchain-link-types,blockchain-link-utils')"
description: 'Array string with names of the packages to deploy. (example: ["blockchain-link-utils","blockchain-link-types","analytics"])'
required: true
type: string
deploymentType:
Expand All @@ -20,7 +20,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
package: ${{ fromJson('[' + github.event.inputs.packages + ']') }}
package: ${{ fromJson(github.event.inputs.packages) }}
steps:
- uses: actions/checkout@v4
with:
Expand Down
6 changes: 3 additions & 3 deletions ci/scripts/connect-release-init-npm.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const ghWorkflowRunReleaseAction = (branch, packages, deployment) =>
'--ref',
branch,
'--field',
`packages="${packages}"`,
`packages=${packages}`,
'--field',
`deploymentType=${deployment}`,
]);
Expand Down Expand Up @@ -212,7 +212,7 @@ const initConnectRelease = async () => {
// and a pull request including all the changes.
// Now we want to trigger the action that will trigger the actual release,
// after approval form authorized member.
const dependenciesToRelease = update.join(',');
const dependenciesToRelease = JSON.stringify(update);
console.log('dependenciesToRelease:', dependenciesToRelease);
console.log('deploymentType:', deploymentType);
console.log('branchName:', branchName);
Expand All @@ -230,7 +230,7 @@ const initConnectRelease = async () => {
console.log('Triggering action to release connect.');
const releaseConnectActionOutput = ghWorkflowRunReleaseAction(
branchName,
['connect', 'connect-web', 'connect-webextension'].join(','),
JSON.stringify(['connect', 'connect-web', 'connect-webextension']),
deploymentType,
);

Expand Down

0 comments on commit c25dbe5

Please sign in to comment.