chore(connect): fw-update: add error message when binary is too small

trezor · May 22, 2024 · 7a72ca9 · 7a72ca9
1 parent 625abf5
commit 7a72ca9
Showing 1 changed file with 20 additions and 10 deletions.
diff --git a/packages/connect/src/core/onCallFirmwareUpdate.ts b/packages/connect/src/core/onCallFirmwareUpdate.ts
@@ -202,17 +202,27 @@ const getBinaryHelper = (
         version: device.firmwareRelease.release.version,
         btcOnly,
         intermediaryVersion,
-    }).then(res => {
-        postMessage(
-            createUiMessage(UI.FIRMWARE_PROGRESS, {
-                device: device.toMessageObject(),
-                operation: 'downloading',
-                progress: 100,
-            }),
-        );
+    })
+        .then(res => {
+            // suspiciously small binary. this typically happens when build does not have git lfs enabled and all
+            // you download here are some pointers to lfs objects which are around ~132 byteLength
+            if (res.byteLength < 200) {
+                throw ERRORS.TypedError('Runtime', 'Firmware binary is too small');
+            }
 
-        return res;
-    });
+            return res;
+        })
+        .then(res => {
+            postMessage(
+                createUiMessage(UI.FIRMWARE_PROGRESS, {
+                    device: device.toMessageObject(),
+                    operation: 'downloading',
+                    progress: 100,
+                }),
+            );
+
+            return res;
+        });
 };
 
 const firmwareCheck = async (