Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): increase maximum passphrase length to 128 bytes #4520

Closed
wants to merge 2 commits into from

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Jan 20, 2025

Fixes #4084.

Legacy is still limited to 50 bytes.

Also, deduplicate common passphrase test vectors definitions.

@romanz romanz self-assigned this Jan 20, 2025
Copy link

github-actions bot commented Jan 20, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz romanz force-pushed the romanz/longer-passphrase branch from dd92be9 to 23e2eff Compare January 21, 2025 09:33
Legacy is still limited to 50 bytes.

Also, deduplicate common passphrase test vectors definitions.
@romanz romanz force-pushed the romanz/longer-passphrase branch from 23e2eff to a0282ad Compare January 21, 2025 11:25
@romanz romanz added the translations Put this label on a PR to run tests in all languages label Jan 21, 2025
@romanz romanz closed this Jan 26, 2025
@romanz
Copy link
Contributor Author

romanz commented Jan 26, 2025

Closing in favor of #4531.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Put this label on a PR to run tests in all languages
Projects
Status: 🏃‍♀️ In progress
Development

Successfully merging this pull request may close these issues.

Remove 50 character limit from passphrase
1 participant