Removed webfontloader package and added Roboto font (fix #45) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chucker
reviewed
Oct 19, 2022
| @@ -0,0 +1,202 @@ | |||
|
|
|||
There was a problem hiding this comment.
Can we have a /ACKNOWLEDGMENTS.md file that lists all products and the paths of their respective licenses (e.g., this one)
There was a problem hiding this comment.
Good thinking. Another thing I didn't think about was that this file isn't even included in the final build (and the license states that it must be included with redistributions and the docker image is a redist).
There was a problem hiding this comment.
this file isn't even included in the final build
Has this changed?
There was a problem hiding this comment.
Where should the ACKNOWLEDGMENTS.md exist? I mean at what URL should it be provided? /ACKNOWLEDGMENTS.md? /.well-known/ACKNOWLEDGMENTS.md?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.