Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove view directory from lib/wanda_web #520

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Remove view directory from lib/wanda_web #520

merged 1 commit into from
Oct 10, 2024

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Oct 9, 2024

Description

A follow up pr to #513
This pr removes the view directory to match Phoenix docs suggestions for Phoenix 1.7.14
https://hexdocs.pm/phoenix/directory_structure.html#the-lib-hello_web-directory

@EMaksy EMaksy self-assigned this Oct 9, 2024
@EMaksy EMaksy changed the title Move json rendering to controller dir and remove view dir Remove view directory from lib/wanda_web Oct 9, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 9, 2024

Coverage Status

coverage: 97.753%. remained the same
when pulling b5824e4 on remove_view_dir
into f2c69dc on main.

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EMaksy EMaksy merged commit 9a030c4 into main Oct 10, 2024
13 checks passed
@EMaksy EMaksy deleted the remove_view_dir branch October 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants