Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license to GPL version 3 or later #15

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Change license to GPL version 3 or later #15

merged 4 commits into from
Sep 26, 2024

Conversation

janvhs
Copy link
Member

@janvhs janvhs commented Sep 23, 2024

The Trento team decided to change the license of the checks to GPL or later. This change is done to keep the checks copyleft during future changes

The Trento team decided to change the license of the checks to GPL or
later.  This change is done to keep the checks copyleft during future
changes
@janvhs
Copy link
Member Author

janvhs commented Sep 23, 2024

I have do double check, that only SUSE employees committed to the checks in the Wanda repo, then this should be it. Otherwise AFAIK we would need to get their OK or leave files they worked on as Apache2 licensed.

I tagged you all to ensure there is no other obligations :D "Speak now or remain silent forever" or something like that

Copy link
Member

@stefanotorresi stefanotorresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of the LICENSE file is supposed to contain the copyright notice stating under which license the software is distributed, not the license itself.

Look at how it was done for the Apache license, and follow the instructions at the bottom of the license text, in the "How to Apply These Terms to Your New Programs" section.

You can omit including the license itself in our source tree, and just put a link to it in the notice.

@janvhs
Copy link
Member Author

janvhs commented Sep 23, 2024

The content of the LICENSE file is supposed to contain the copyright notice stating under which license the software is distributed, not the license itself.

Look at how it was done for the Apache license, and follow the instructions at the bottom of the license text, in the "How to Apply These Terms to Your New Programs" section.

You can omit including the license itself in our source tree, and just put a link to it in the notice.

@stefanotorresi Maybe it is different with Apache, but with GPL you put the whole license text into the LICENSE or COPYING file. See https://gitlab.gnome.org/GNOME/gnome-terminal, https://github.com/openSUSE/snapper/blob/master/COPYING or a GNU program https://git.savannah.gnu.org/cgit/tar.git/tree/COPYING for reference.

There is zypper, which does it in a similar way to what you proposed, https://github.com/openSUSE/zypper/blob/master/COPYING . Please have a look and pick one of those options

@stefanotorresi
Copy link
Member

@stefanotorresi Maybe it is different with Apache, but with GPL you put the whole license text into the LICENSE or COPYING file. See https://gitlab.gnome.org/GNOME/gnome-terminal, https://github.com/openSUSE/snapper/blob/master/COPYING or a GNU program https://git.savannah.gnu.org/cgit/tar.git/tree/COPYING for reference.

This has nothing to do with the license: the copyright information notice and the license itself are two different pieces of documentation, and they can live in different places. In our case, we want to only put a link to the actual license, and shorten the notice to something that basically states "This project is licensed this way. If you want to read the license, here is a link".

There is zypper, which does it in a similar way to what you proposed, https://github.com/openSUSE/zypper/blob/master/COPYING . Please have a look and pick one of those options

Exactly, this is very similar to what I am requesting, and it's consistent with how we do it in the other repos.
I don't think we need to rename the LICENSE document to COPYING, but if you feel strongly about it (I can agree that technically the document is not the license itself, but copying instructions), then do it, but you'd need to do it for all the repos to keep consistency.

As requested by Stefano Torresi, this request replaces the license text
with a reference on where to obtain the license source text
Copy link
Member

@stefanotorresi stefanotorresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, a few tweaks before we're done.

LICENSE Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
@janvhs
Copy link
Member Author

janvhs commented Sep 25, 2024

@stefanotorresi It's directly copied from the GPL license, but I can do that

@janvhs janvhs requested review from stefanotorresi and removed request for nelsonkopliku, CDimonaco and arbulu89 September 26, 2024 09:27
@stefanotorresi stefanotorresi merged commit f10ae9b into main Sep 26, 2024
5 checks passed
@stefanotorresi stefanotorresi deleted the GPL-baby branch September 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants