Improve crash on failed agent initialization #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtorrero
added
enhancement
arbulu89
reviewed
Mar 5, 2024
| return err | ||
| } | ||
| g.Go(func() error { | ||
|
|
There was a problem hiding this comment.
Can we remove this 86 empty line?
And maybe put a new line before g.Go
rtorrero
force-pushed
the
pre-discovery-checks
branch
from
bd5ef57
to
7ef9ae5
Compare
arbulu89
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
We achieve this by:
Start()Start()until it is resolved. The listen part is the blocking part, so that needs to stay in the Go routineNOTE: I also explored what would happen on wrong configuration files, e.g. following the example of the slack conversation from TRNT-2814, I removed
facts-service-urland this seems that was already causing the agent to crash without a heartbeat nor discovery loops starting(Addresses TRNT-2814)