WebUI: Sanitize user-input fields of PRs #8271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaigilo
added
the
include-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
N-o-Z
approved these changes
Oct 8, 2024
arielshaqed
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Not a fan. For instance, this prevents me from having a PR title "Fix <b> tags":
- If I try to type it in, it helpfully purifies the first
<and I get "Fix <b> tags". - If you set it on the server directly through the API and I try to read it from the GUI, I see "
Fix <b> tags</b>".
Neither is correct.
In fact I expect React {...} to protect me! So I would also expect React-Bootstrap components to inherit this behaviour. This protection would would kinda protect some other bad website, or some broken component in our web UI, from failing, one that presumably runs React dangerouslySetInnerHTML or simply allows HTML injection.
Additionally, this enforces that I cannot use the GUI to enter a string that we might fear. But I can still use the API to enter the exact same string.
Basically, I believe that clients need to protect themselves when reading code, correctly. Not sure this is the way ;-(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8203.
Change Description
Adding sanitize for user-input fields of a PR, to prevent malicious attacks.
Currently it's only relevant for title + description when creating a PR.
Using the very popular DOMPurify package.
Testing Details
Verified manually that PR creation still works.