-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content to index pages of /understand #6270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmoff
commented
Jul 27, 2023
- Remove default layout metadata
- It's the only layout
- It's the default anyway
- It adds unnecessary content to the front page matter metadata for pages, making it more likely to make a mistake editing what is there
- Add content to index pages of /understand, fix a few page nits
- It's the only layout - It's the default anyway - It adds unnecessary content to the front page matter metadata for pages, making it more likely to make a mistake editing what is there
rmoff
added
docs
Improvements or additions to documentation
exclude-changelog
PR description should not be included in next release changelog
minor-change
Used for PRs that don't require issue attached
labels
Jul 27, 2023
🎊 PR Preview 744e169 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-6270.surge.sh 🕐 Build time: 0.018s 🤖 By surge-preview |
ozkatz
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both welcomed changes, thank you!
rmoff
pushed a commit
that referenced
this pull request
Jul 27, 2023
* Remove default layout metadata - It's the only layout - It's the default anyway - It adds unnecessary content to the front page matter metadata for pages, making it more likely to make a mistake editing what is there * Add content to index pages of /understand, fix a few page nits * Always that file you forget to update 🤦🏻
rmoff
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Add diagrams to deploy docs Move GC docs into their own folder * Tidy up and restructure GC docs * Update links from UI to point to current docs pages instead of relying on redirects * Add content to how-to index page * Docs nits * Fix links * Fix links * Fix links * Fix typo in output * Use live reload in docs-serve * Fix broken links * Fix broken links * Metaclient: handle initial commit (#6263) * Add ssl optional configuration (#6268) * Added SSL Certificate_verfified_Failed * add proxy configuration * Fix broken link to API doc (#6271) * Add content to index pages of /understand (#6270) * Remove default layout metadata - It's the only layout - It's the default anyway - It adds unnecessary content to the front page matter metadata for pages, making it more likely to make a mistake editing what is there * Add content to index pages of /understand, fix a few page nits * Always that file you forget to update 🤦🏻 * Add diagrams to deploy docs Move GC docs into their own folder * Reword deploy doc * Fix links * Reword GCP lakefs CLoud callout --------- Co-authored-by: Yoni <[email protected]> Co-authored-by: iddoavn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Improvements or additions to documentation
exclude-changelog
PR description should not be included in next release changelog
minor-change
Used for PRs that don't require issue attached
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.