Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content to index pages of /understand #6270

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Conversation

rmoff
Copy link
Contributor

@rmoff rmoff commented Jul 27, 2023

  • Remove default layout metadata
    • It's the only layout
    • It's the default anyway
    • It adds unnecessary content to the front page matter metadata for pages, making it more likely to make a mistake editing what is there
  • Add content to index pages of /understand, fix a few page nits

rmoff added 2 commits July 27, 2023 17:14
- It's the only layout
- It's the default anyway
- It adds unnecessary content to the front page matter metadata for pages, making it more likely to make a mistake editing what is there
@rmoff rmoff added docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Jul 27, 2023
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

🎊 PR Preview 744e169 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-6270.surge.sh

🕐 Build time: 0.018s

🤖 By surge-preview

Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both welcomed changes, thank you!

@rmoff rmoff merged commit feb2d41 into master Jul 27, 2023
17 checks passed
@rmoff rmoff deleted the docs/5470-understanding branch July 27, 2023 17:49
rmoff pushed a commit that referenced this pull request Jul 27, 2023
* Remove default layout metadata
- It's the only layout
- It's the default anyway
- It adds unnecessary content to the front page matter metadata for pages, making it more likely to make a mistake editing what is there

* Add content to index pages of /understand, fix a few page nits

* Always that file you forget to update 🤦🏻
rmoff pushed a commit that referenced this pull request Aug 14, 2023
* Add diagrams to deploy docs
Move GC docs into their own folder

* Tidy up and restructure GC docs

* Update links from UI to point to current docs pages instead of relying on redirects

* Add content to how-to index page

* Docs nits

* Fix links

* Fix links

* Fix links

* Fix typo in output

* Use live reload in docs-serve

* Fix broken links

* Fix broken links

* Metaclient: handle initial commit (#6263)

* Add ssl optional configuration (#6268)

* Added SSL Certificate_verfified_Failed

* add proxy configuration

* Fix broken link to API doc (#6271)

* Add content to index pages of /understand (#6270)

* Remove default layout metadata
- It's the only layout
- It's the default anyway
- It adds unnecessary content to the front page matter metadata for pages, making it more likely to make a mistake editing what is there

* Add content to index pages of /understand, fix a few page nits

* Always that file you forget to update 🤦🏻

* Add diagrams to deploy docs
Move GC docs into their own folder

* Reword deploy doc

* Fix links

* Reword GCP lakefs CLoud callout

---------

Co-authored-by: Yoni <[email protected]>
Co-authored-by: iddoavn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants