Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Requests: Sanitize to user provided fields #8203

Open
N-o-Z opened this issue Sep 20, 2024 · 3 comments · May be fixed by #8271
Open

Pull Requests: Sanitize to user provided fields #8203

N-o-Z opened this issue Sep 20, 2024 · 3 comments · May be fixed by #8271
Assignees
@itaigilo
Labels
pull-requests tech-debt

Comments

@N-o-Z
Copy link
Member

N-o-Z commented Sep 20, 2024

We should sanitize any user inputted fields in pull requests such as Title and Description to avoid potentially malicious attacks
@arielshaqed
Copy link
Contributor

In case this is not part of the plan: It's cool to do it on the backend, but please (also) protect when inserting the user provided fields into the DOM. So it really needs to be based on an allowlist rather than on a blocklist. That list can come (and probably should) from an existing React library, of course.

@N-o-Z
Copy link
Member Author

N-o-Z commented Oct 2, 2024

@itaigilo I think this is something we can do this current sprint. WDYT?

@itaigilo
Copy link
Contributor

itaigilo commented Oct 2, 2024

@itaigilo I think this is something we can do this current sprint. WDYT?

Yeah, I guess so.
Will do it on my next workday.

@itaigilo itaigilo self-assigned this Oct 2, 2024
@itaigilo itaigilo linked a pull request Oct 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itaigilo itaigilo

Labels
pull-requests tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WebUI: Sanitize user-input fields of PRs treeverse/lakeFS
3 participants
@N-o-Z @arielshaqed @itaigilo