Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External auth example #245

Merged
merged 8 commits into from
Apr 14, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,3 @@ jobs:
uses: helm/[email protected]
env:
CR_TOKEN: "${{ secrets.CR_TOKEN }}"

4 changes: 4 additions & 0 deletions charts/lakefs/templates/_env.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ env:
- name: LAKEFS_AUTH_UI_CONFIG_LOGOUT_URL
value: /logout
{{- end }}
{{- if (.Values.fluffy.sso).enabled }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that this if is not required because there's one in L35 that wraps it and ends in L60

please verify me

- name: LAKEFS_AUTH_AUTHENTICATION_API_ENDPOINT
value: {{ printf "http://%s/api/v1" (include "fluffy.ssoServiceName" .) | quote }}
{{- end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump Chart.yaml version

{{- end }}
{{- if (.Values.fluffy.rbac).enabled }}
- name: LAKEFS_AUTH_API_ENDPOINT
Expand Down
59 changes: 59 additions & 0 deletions examples/lakefs/enterprise/values-external-aws.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
lakefsConfig: |
Isan-Rivkin marked this conversation as resolved.
Show resolved Hide resolved
logging:
level: "INFO"
blockstore:
type: local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

auth:
authentication_api:
endpoint: http://localhost:8080/api/v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this still here?

external_principals_enabled: true
ingress:
enabled: true
ingressClassName: <class-name>
hosts:
# the ingress that will be created for lakeFS
- host: <lakefs.ingress.domain>
paths:
- /

##################################################
########### lakeFS enterprise - FLUFFY ###########
##################################################

fluffy:
enabled: true
image:
repository: treeverse/fluffy
tag: '0.3.0'
pullPolicy: IfNotPresent
privateRegistry:
enabled: true
secretToken: <dockerhub-token-fluffy-image>
fluffyConfig: |
logging:
format: "json"
level: "INFO"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

auth:
external:
aws_auth:
enabled: true
# the maximum age in seconds for the GetCallerIdentity request
#get_caller_identity_max_age: 60
# list of headers that are required to be present in the GetCallerIdentity request
#required_headers:
# x-lakefs-custom-key: "custom-value"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#required_headers:
# x-lakefs-custom-key: "custom-value"
# headers that must be present by the client when doing login request
required_headers:
# same host as the lakeFS server ingress
X-LakeFS-Server-ID: <lakefs.ingress.domain>

# list of headers that are optional for the GetCallerIdentity request
#optional_headers:
# optional-key: "custom-value"
# list of valid STS hosts for the GetCallerIdentity request
#valid_sts_hosts:
# - "sts.amazonaws.com"
# - "sts.us-east-1.amazonaws.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's really an advanced use case for someone to use that, i think its confusing, remove

secrets:
create: true
sso:
enabled: true
rbac:
enabled: true

Isan-Rivkin marked this conversation as resolved.
Show resolved Hide resolved
useDevPostgres: true
2 changes: 1 addition & 1 deletion examples/lakefs/enterprise/values-oidc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ fluffy:
enabled: true
image:
repository: treeverse/fluffy
tag: '0.2.7'
tag: '0.3.0'
pullPolicy: IfNotPresent
privateRegistry:
enabled: true
Expand Down
Loading