footprint add possibility to ignore models #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-wyatt
reviewed
Nov 14, 2017
|
Because unfortunately the footprint controller and policy are here so no other choice to put this here... If there were in trailpack-footprint no problem to put everything there |
|
Currently trailpack-footprint is basically empty... it just provide the footprint configuration and routes but not the implementation of those |
|
@scott-wyatt another way of doing that under trailpack-footprint is to stop using generic routes for model footprint and start using dedicated route for each models, like this if models are ignored we just don't add the routes for this models, what do you think ? It will also work for both hapi and express when here it's only express. Sound much better |
|
Can I merge this @scott-wyatt ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with this, under config.footprint.models we can have an array of ignored models like controllers, if a footprint is called on an ignored model a 403 is returned