Better relative paths handling and returning more useful values from API #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 31, 2013 03:34
Nested paths like 'bundle/public/{}' (containing more than one path
separator) were not detected as relative. Thus they were passed to
`surround`, instead of `incubate`.
If pathogen#incubate() was called for a non-default relative path and nothing was found in runtimepath - it will "fallback" to pathogen#surround(). It will also protect absolute/relative path detection logic from failing on some platforms, like windows.
|
Official interface is |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that a suggested fallback from incubate to surround will work on windows, but looks logically.
Returning path lists, that were just loaded, is very useful for plugins, that use pathogen's internal API. i.e. I've created my own vim-profiles plugin, that uses this feature. Also vim-ipi may benefit from this change, since now it is forced to make extra rtp value comparison before and after pathogen invocation to detect loaded plugins.