Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove fake-esm build #38

Merged
merged 3 commits into from
Jan 2, 2025
Merged

fix: remove fake-esm build #38

merged 3 commits into from
Jan 2, 2025

Conversation

saehun
Copy link
Contributor

@saehun saehun commented Jan 2, 2025

Overview

Since "module": "esnext" cannot interopable with Pure ESM, It prevent pure ESM codebase from loading proper javascript file.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v3

- name: Setup pnpm
uses: pnpm/action-setup@v2.2.4
- uses: pnpm/action-setup@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saehun saehun requested a review from WhiteKiwi January 2, 2025 07:05
@WhiteKiwi WhiteKiwi merged commit 1ecdc3a into v2.x Jan 2, 2025
1 check passed
@WhiteKiwi WhiteKiwi deleted the fix/remove-esm branch January 2, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants