Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: remove some internal types in preference for aquatics #961

Merged
merged 6 commits into from
Aug 24, 2024

Conversation

da2ce7
Copy link
Contributor

@da2ce7 da2ce7 commented Jul 13, 2024

Prefer the protocol types in https://github.com/greatest-ape/aquatic/tree/master

  • Removed AnnounceEvent for aquatic type.
  • InfoHash uses aquatic type internally.
  • Use aquatic PeerId and peer::Id uses aquatic type internally.

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 90.52632% with 18 lines in your changes missing coverage. Please review.

Project coverage is 77.23%. Comparing base (efc2a76) to head (bef5680).
Report is 7 commits behind head on develop.

Files Patch % Lines
packages/primitives/src/peer.rs 79.10% 14 Missing ⚠️
...t_torrent/tracker/http/client/requests/announce.rs 0.00% 2 Missing ⚠️
src/servers/http/v1/requests/announce.rs 90.90% 1 Missing ⚠️
..._torrent/tracker/http/client/responses/announce.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #961      +/-   ##
===========================================
+ Coverage    77.16%   77.23%   +0.06%     
===========================================
  Files          185      178       -7     
  Lines        10069    10063       -6     
===========================================
+ Hits          7770     7772       +2     
+ Misses        2299     2291       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@da2ce7 da2ce7 force-pushed the 20240713_remove_wrapper_types branch from 003963f to 8d4b6f8 Compare July 13, 2024 22:33
@da2ce7 da2ce7 force-pushed the 20240713_remove_wrapper_types branch from 8d4b6f8 to 23b1106 Compare July 14, 2024 13:44
@da2ce7 da2ce7 force-pushed the 20240713_remove_wrapper_types branch from 99c83af to 49cb12c Compare July 15, 2024 10:06
@da2ce7 da2ce7 marked this pull request as ready for review July 15, 2024 10:11
@da2ce7 da2ce7 changed the title dev: remove announce_request wrapper dev: remove some internal types in preference for aquatics Jul 16, 2024
@da2ce7
Copy link
Contributor Author

da2ce7 commented Aug 24, 2024

ACK bef5680

@da2ce7 da2ce7 merged commit f79a019 into torrust:develop Aug 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant