-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: remove some internal types in preference for aquatics #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #961 +/- ##
===========================================
+ Coverage 77.16% 77.23% +0.06%
===========================================
Files 185 178 -7
Lines 10069 10063 -6
===========================================
+ Hits 7770 7772 +2
+ Misses 2299 2291 -8 ☔ View full report in Codecov by Sentry. |
da2ce7
force-pushed
the
20240713_remove_wrapper_types
branch
from
July 13, 2024 22:33
003963f
to
8d4b6f8
Compare
da2ce7
force-pushed
the
20240713_remove_wrapper_types
branch
from
July 14, 2024 13:44
8d4b6f8
to
23b1106
Compare
da2ce7
force-pushed
the
20240713_remove_wrapper_types
branch
from
July 15, 2024 10:06
99c83af
to
49cb12c
Compare
da2ce7
changed the title
dev: remove announce_request wrapper
dev: remove some internal types in preference for aquatics
Jul 16, 2024
da2ce7
force-pushed
the
20240713_remove_wrapper_types
branch
from
August 24, 2024 13:02
49cb12c
to
bef5680
Compare
ACK bef5680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer the protocol types in https://github.com/greatest-ape/aquatic/tree/master
AnnounceEvent
for aquatic type.InfoHash
uses aquatic type internally.PeerId
andpeer::Id
uses aquatic type internally.