Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1040: continue when finding errors #1064

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

abstralexis
Copy link
Contributor

Fix the behaviour of UDP checks exiting on first fail (#1040). Was breaking instead of continueing when iterating over each test.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.32%. Comparing base (cb9e345) to head (a34f66e).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1064   +/-   ##
========================================
  Coverage    77.32%   77.32%           
========================================
  Files          178      178           
  Lines        10269    10269           
========================================
  Hits          7940     7940           
  Misses        2329     2329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abstralexis
Copy link
Contributor Author

Retroactively signed the commit - I didn't have GPG keys set up on my laptop for some reason 😅

@josecelano josecelano linked an issue Oct 17, 2024 that may be closed by this pull request
@josecelano josecelano added this to the v3.1.0 milestone Oct 17, 2024
@josecelano josecelano added the Bug Incorrect Behavior label Oct 17, 2024
Copy link
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abstralexis thank you very much for your contribution.

I've tried with two trackers, one working and the other failing:

TORRUST_CHECKER_CONFIG='{
    "udp_trackers": ["127.0.0.1:6969", "udp://tracker.torrust-demo.com:6969"],
    "http_trackers": [],
    "health_checks": []
}' cargo run --bin tracker_checker 

@josecelano
Copy link
Member

ACK a34f66e

@josecelano josecelano merged commit 105dfc1 into torrust:develop Oct 17, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect Behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracker Checker (UDP): Don't stop on the first fail
2 participants