Wagtail 6.0 support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old tests relied on the assumption that page.save_revision() was an accurate representation of what happens when saving a draft edit in the admin. On Wagtail 6, saving a draft also updates the real database record if the page is not live, meaning that it is no longer a stable place to stash the 'approved' revision as it was when the experiment was activated.
gasman
force-pushed
the
fix/wagtail-6
branch
from
b378d9a to
8da94b0
Compare
gasman
force-pushed
the
fix/wagtail-6
branch
from
5777024 to
8fd910f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Wagtail 6.0 we can no longer rely on the real database records of draft pages to preserve the revision that was active when the experiment was made live, because the real database record is now updated on draft edits (wagtail/wagtail#10104). Fix this by storing explicit revision IDs (as suggested in wagtail/wagtail#10104 (comment)).