Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FX-6095] Add type to number input button controls #4604

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[FX-6095] Add type to number input button controls #4604

merged 2 commits into from
Oct 15, 2024

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Oct 15, 2024 •
edited
Loading

FX-6095

Description

This pull request restore type="button" in NumberInput. Without proper type, HTML form considers these buttons as submit ones, which brings the problem similar to the one demonstrated in Jira ticket.

How to test

Kapture.2024-10-15.at.12.53.51.mp4

Development checks

  • Add changeset according to guidelines (if needed)
  • [N/A] Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • [N/A] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • [N/A] Annotate all props in component with documentation
  • [N/A] Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • [N/A] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Oct 15, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 353a18c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@toptal/picasso-number-input Patch
@toptal/picasso Patch
@toptal/picasso-forms Patch
@toptal/picasso-query-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk marked this pull request as ready for review October 15, 2024 11:35
@sashuk sashuk requested a review from a team as a code owner October 15, 2024 11:35
@sashuk
Copy link
Contributor Author

sashuk commented Oct 15, 2024

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@56.0.6-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/base-tailwind@1.0.1-alpha-fx-6095-number-input-misses-type-button-353a18c00.41+353a18c00
yarn add @toptal/picasso@53.0.1-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-accordion@3.0.14-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-account-select@3.0.12-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-alert@3.0.26-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-amount@1.0.10-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-application-update-notification@2.0.26-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-autocomplete@5.0.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-avatar@6.1.6-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-avatar-upload@3.0.17-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-backdrop@1.0.9-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-badge@3.0.4-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-breadcrumbs@3.0.6-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-button@4.0.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-calendar@4.0.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-carousel@4.0.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-charts@59.0.4-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-checkbox@5.0.7-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-codemod@6.0.1-alpha-fx-6095-number-input-misses-type-button-353a18c00.297+353a18c00
yarn add @toptal/picasso-collapse@3.0.3-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-container@3.1.2-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-date-picker@3.0.13-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-date-select@1.0.62-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-drawer@3.0.26-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-dropdown@4.2.2-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-dropzone@5.0.14-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-empty-state@2.0.9-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-environment-banner@3.0.1-alpha-fx-6095-number-input-misses-type-button-353a18c00.92+353a18c00
yarn add @toptal/picasso-fade@1.0.8-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-file-input@4.0.13-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-form@6.1.5-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-forms@73.0.16-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-grid@5.0.5-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-helpbox@5.0.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-icons@1.8.2-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-image@3.0.3-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-input@4.0.13-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-input-adornment@3.0.6-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-link@3.0.5-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-list@5.0.6-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-loader@3.0.3-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-logo@2.0.5-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-menu@3.0.11-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-modal@3.0.26-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-modal-context@1.0.2-alpha-fx-6095-number-input-misses-type-button-353a18c00.356+353a18c00
yarn add @toptal/picasso-note@4.0.4-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-notification@4.0.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-number-input@4.0.13-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-outlined-input@4.0.13-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-overview-block@4.0.4-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-page@5.1.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-pagination@4.0.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-paper@4.0.3-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-password-input@5.0.13-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-pictograms@5.0.3-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-popper@1.0.6-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-prompt-modal@2.0.26-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-provider@5.0.1-alpha-fx-6095-number-input-misses-type-button-353a18c00.175+353a18c00
yarn add @toptal/picasso-query-builder@8.0.5-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-quote@2.0.6-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-radio@5.0.7-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-rating@3.0.6-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-rich-text-editor@17.0.13-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-section@5.0.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-select@4.0.13-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-shared@15.0.1-alpha-fx-6095-number-input-misses-type-button-353a18c00.254+353a18c00
yarn add @toptal/picasso-show-more@2.0.14-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-skeleton-loader@1.0.51-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-slide@1.0.3-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-slider@4.0.4-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-step@4.0.5-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-switch@4.0.6-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-table@3.0.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-tabs@5.0.8-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-tag@4.0.6-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-tagselector@3.1.15-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-tailwind@3.0.1-alpha-fx-6095-number-input-misses-type-button-353a18c00.41+353a18c00
yarn add @toptal/picasso-tailwind-merge@2.0.3-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-test-utils@1.1.2-alpha-fx-6095-number-input-misses-type-button-353a18c00.254+353a18c00
yarn add @toptal/picasso-timeline@5.0.4-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-timepicker@4.0.13-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-tooltip@2.0.2-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-tree-view@3.0.27-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-typography@4.0.3-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-typography-overflow@4.0.3-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-user-badge@5.1.7-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00
yarn add @toptal/picasso-utils@3.0.1-alpha-fx-6095-number-input-misses-type-button-353a18c00.1+353a18c00

@sashuk
Copy link
Contributor Author

sashuk commented Oct 15, 2024

@toptal-anvil ping reviewers

@sashuk sashuk requested a review from a team October 15, 2024 12:01
@sashuk sashuk merged commit 1ba3f82 into master Oct 15, 2024
31 of 32 checks passed
@sashuk sashuk deleted the fx-6095-number-input-misses-type-button branch October 15, 2024 14:21
@toptal-build toptal-build mentioned this pull request Oct 15, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaklygin dmaklygin dmaklygin approved these changes

Assignees

@sashuk sashuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sashuk @toptal-devbot @dmaklygin