Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TI-2890] Add sparkle icon #4598

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[TI-2890] Add sparkle icon #4598

merged 1 commit into from
Oct 9, 2024

Conversation

sofiaternovskaya
Copy link
Contributor

@sofiaternovskaya sofiaternovskaya commented Oct 9, 2024

TI-2890

Description

Add sparkle icon

How to test

  • Check storybook

Screenshots

image

Development checks

  • Add changeset according to guidelines (if needed)
  • [-] Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • [-] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • [-] Annotate all props in component with documentation
  • [-] Create examples for component
  • [-] Ensure that deployed demo has expected results and good examples
  • [-] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • [-] Covered with tests (visual tests included)

Breaking change

  • [-] codemod is created and showcased in the changeset
  • [-] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sofiaternovskaya sofiaternovskaya added the Talent Insights Talent Insights team label Oct 9, 2024
@sofiaternovskaya sofiaternovskaya self-assigned this Oct 9, 2024
@sofiaternovskaya sofiaternovskaya requested a review from a team as a code owner October 9, 2024 09:47
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 75ef893

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@toptal/picasso-icons Minor
@toptal/picasso-forms Patch
@toptal/picasso-query-builder Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso Patch
@toptal/picasso-accordion Patch
@toptal/picasso-account-select Patch
@toptal/picasso-alert Patch
@toptal/picasso-application-update-notification Patch
@toptal/picasso-avatar Patch
@toptal/picasso-avatar-upload Patch
@toptal/picasso-breadcrumbs Patch
@toptal/picasso-button Patch
@toptal/picasso-calendar Patch
@toptal/picasso-carousel Patch
@toptal/picasso-date-picker Patch
@toptal/picasso-drawer Patch
@toptal/picasso-dropzone Patch
@toptal/picasso-empty-state Patch
@toptal/picasso-file-input Patch
@toptal/picasso-form Patch
@toptal/picasso-grid Patch
@toptal/picasso-helpbox Patch
@toptal/picasso-input Patch
@toptal/picasso-input-adornment Patch
@toptal/picasso-list Patch
@toptal/picasso-logo Patch
@toptal/picasso-menu Patch
@toptal/picasso-modal Patch
@toptal/picasso-notification Patch
@toptal/picasso-number-input Patch
@toptal/picasso-outlined-input Patch
@toptal/picasso-page Patch
@toptal/picasso-password-input Patch
@toptal/picasso-rating Patch
@toptal/picasso-section Patch
@toptal/picasso-select Patch
@toptal/picasso-show-more Patch
@toptal/picasso-step Patch
@toptal/picasso-table Patch
@toptal/picasso-tabs Patch
@toptal/picasso-tag Patch
@toptal/picasso-timepicker Patch
@toptal/picasso-user-badge Patch
@toptal/picasso-pagination Patch
@toptal/picasso-prompt-modal Patch
@toptal/picasso-skeleton-loader Patch
@toptal/picasso-tree-view Patch
@toptal/picasso-autocomplete Patch
@toptal/picasso-checkbox Patch
@toptal/picasso-radio Patch
@toptal/picasso-switch Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-date-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptal-devbot toptal-devbot added the contribution DO NOT ADD MANUALLY label Oct 9, 2024
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @sofiaternovskaya 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@sofiaternovskaya
Copy link
Contributor Author

@toptal-anvil ping reviewers

@TomasSlama TomasSlama merged commit f8cb675 into master Oct 9, 2024
21 of 27 checks passed
@TomasSlama TomasSlama deleted the ti-2890 branch October 9, 2024 15:47
@toptal-build toptal-build mentioned this pull request Oct 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY Talent Insights Talent Insights team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants