Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-6047] Fix UserBadge padding in PageTopBarMenu #4589

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

ruslan-sed
Copy link
Contributor

@ruslan-sed ruslan-sed commented Oct 3, 2024

FX-6047

Description

Describe the changes and motivations for the pull request.

How to test

  1. Go to PageTopBar stories page.
  2. Go to Page.TopBar.Menu stories.
  3. Change screen size to <1000px and click on avatar in the right corner of PageTopBar.

Screenshots

Before. After.
image image

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@ruslan-sed ruslan-sed self-assigned this Oct 3, 2024
Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: d3d2ee9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@toptal/picasso-user-badge Patch
@toptal/picasso-page Patch
@toptal/picasso Patch
@toptal/picasso-account-select Patch
@toptal/picasso-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ruslan-sed ruslan-sed force-pushed the fx-6047-fix-pagetopbar-menu-padding branch 3 times, most recently from 1f677eb to d627ae4 Compare October 3, 2024 10:04
@ruslan-sed ruslan-sed marked this pull request as ready for review October 3, 2024 11:03
@ruslan-sed ruslan-sed requested a review from a team as a code owner October 3, 2024 11:03
@ruslan-sed
Copy link
Contributor Author

@toptal-anvil ping reviewers

1 similar comment
@ruslan-sed
Copy link
Contributor Author

@toptal-anvil ping reviewers

@ruslan-sed ruslan-sed force-pushed the fx-6047-fix-pagetopbar-menu-padding branch from 5933f32 to f6cd05f Compare October 4, 2024 07:53
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on temploy, visual test additions looks good too!

@ruslan-sed
Copy link
Contributor Author

@toptal-anvil ping reviewers

@ruslan-sed ruslan-sed merged commit 0dda7dc into master Oct 7, 2024
18 checks passed
@ruslan-sed ruslan-sed deleted the fx-6047-fix-pagetopbar-menu-padding branch October 7, 2024 10:46
@toptal-build toptal-build mentioned this pull request Oct 7, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants