-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[CPT-2535] Add property to place accordion icon on the left" #4526
Revert "[CPT-2535] Add property to place accordion icon on the left" #4526
Conversation
🦋 Changeset detectedLatest commit: 4150c3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Greetings from FX team, @angelinastavniiciuc 👋 Thank you so much for contributing 🙇 We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme! What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉 🙏 please, help us improve, rate your contributing experience after merge |
@angelinastavniiciuc Can you please add changeset? |
@sashuk yup, on it, just not sure which bump should it be major or minor ? and whether I should include all changed packages or only accordion ? |
This should be a major one, as new public API of Accordion is going to be incompatible with the old one
Let's include all packages that changeset will mark as "updated" |
@sashuk can you please help with failing Happo check ? (it is because the added visual test was removed now) |
@angelinastavniiciuc Done! |
Reverts #4522