-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-5657] Migrate ShowMore to Tailwind #4517
Conversation
🦋 Changeset detectedLatest commit: 511e0fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
50da42e
to
46ce077
Compare
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left few comments, please take a look. Because of the bug that you mentioned in the description, I couldn't test properly as I couldn't open the Safe Mode. It seems to work fine in temploy though, but I'm not sure that it's enough.
packages/base/ShowMore/src/ShowMore/__snapshots__/test.tsx.snap
Outdated
Show resolved
Hide resolved
@AdrianContiu Good point, I added recommendations how to launch branch locally in the pull request description |
46ce077
to
f9a26d3
Compare
f9a26d3
to
511e0fc
Compare
FX-5657
Description
This pull request migrate
ShowMore
to TailwindCSS.The https://toptal-core.atlassian.net/browse/FX-5870 was created along the way.
How to test
.storybook/main.js
to make it runDevelopment checks
picasso-tailwind-merge
requires major update (check itsREADME.md
)PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?