Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-5657] Migrate ShowMore to Tailwind #4517

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Aug 30, 2024

FX-5657

Description

This pull request migrate ShowMore to TailwindCSS.

The https://toptal-core.atlassian.net/browse/FX-5870 was created along the way.

How to test

   reactOptions: {
     fastRefresh: true,
-    strictMode: true,
+    strictMode: false,
   },

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Aug 30, 2024
Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: 511e0fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso-show-more Major
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk marked this pull request as ready for review August 30, 2024 12:10
@sashuk sashuk requested a review from a team as a code owner August 30, 2024 12:10
@AdrianContiu AdrianContiu self-requested a review August 30, 2024 12:15
@sashuk
Copy link
Contributor Author

sashuk commented Aug 30, 2024

@toptal-anvil ping reviewers

Copy link
Contributor

@AdrianContiu AdrianContiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few comments, please take a look. Because of the bug that you mentioned in the description, I couldn't test properly as I couldn't open the Safe Mode. It seems to work fine in temploy though, but I'm not sure that it's enough.

packages/base/ShowMore/src/ShowMore/ShowMore.tsx Outdated Show resolved Hide resolved
@sashuk
Copy link
Contributor Author

sashuk commented Aug 30, 2024

I couldn't open the Safe Mode. It seems to work fine in temploy though, but I'm not sure that it's enough.

@AdrianContiu Good point, I added recommendations how to launch branch locally in the pull request description

@sashuk sashuk requested a review from a team August 30, 2024 16:39
@sashuk sashuk merged commit e551bb5 into master Sep 2, 2024
18 checks passed
@sashuk sashuk deleted the fx-5657-showmore-dcd8202 branch September 2, 2024 07:53
@toptal-build toptal-build mentioned this pull request Sep 2, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants