This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
Create State and Transition traits #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4l0n50
changed the base branch from
interpreter-unification
to
interpreter-unified
4l0n50
commented
Feb 26, 2024
| } | ||
|
|
||
| /// Skips the following instructions for some specific labels | ||
| fn skip_if_necessary(&mut self, op: Operation) -> Result<Operation, ProgramError>; |
There was a problem hiding this comment.
This method is begging for a better name. Any idea?
4l0n50
commented
Feb 26, 2024
Nashtare
reviewed
Feb 26, 2024
LindaGuiga
reviewed
Feb 26, 2024
Nashtare
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Unify interpreter and CPU logic. * Cleanup * Update CHANGELOG * Cleanup * Apply comments * Remove extra STARK pushes * Clippy * Remove new_with_kernel * Fix extend_memory * Create State and Transition traits (#1) * Add traits State and Transition * Move perform_state_op to Transition * Fix bug * Get rid of is_generation_state + add reviews * Remove TDO * Fix handle_error * Move preinitialized_segments from the interpreter to MemoryState * Clippy * Apply get_halt_context comment --------- Co-authored-by: Linda Guiga <[email protected]> * Apply comments * Remove incr_interpreter_clock --------- Co-authored-by: Alonso González <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
enum Statetotrait State, which is implemented byInterpreterandGenerationState. TheStatetrait require to implement the same methods of the previous enum, and implements the ones having the old enum as input (for examplerun_cpu) . It also required to create a new traitTransition: Statewhich implements some the the functions intrasition.rsand require to implement others related to the state transition.