Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: update and expose prometheus metrics and grafana #273

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Conversation

hadjiszs
Copy link
Member

@hadjiszs hadjiszs commented Aug 2, 2023

Description

  • get back some removed metrics
  • add prometheus labels (run_id, run_number)
  • add the delivery latency metric
  • update the grafana dashboard

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@hadjiszs hadjiszs requested a review from a team as a code owner August 2, 2023 00:49
@hadjiszs hadjiszs requested review from Freyskeyd and gruberb and removed request for a team August 2, 2023 00:49
@hadjiszs hadjiszs force-pushed the feat/TP-647 branch 2 times, most recently from 2799026 to 787f8b7 Compare August 2, 2023 00:52
crates/topos-metrics/src/api.rs Show resolved Hide resolved
@hadjiszs hadjiszs force-pushed the chore/optional-certificate-size branch from 381ab78 to 9f5dfc5 Compare August 2, 2023 18:51
Base automatically changed from chore/optional-certificate-size to main August 3, 2023 08:36
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #273 (4bc6102) into main (fc27d4b) will increase coverage by 0.22%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   52.57%   52.80%   +0.22%     
==========================================
  Files         206      207       +1     
  Lines        9809     9833      +24     
==========================================
+ Hits         5157     5192      +35     
+ Misses       4652     4641      -11     
Files Changed Coverage Δ
crates/topos-tce-broadcast/src/lib.rs 89.13% <ø> (ø)
...opos-tce-broadcast/src/task_manager_futures/mod.rs 84.61% <ø> (ø)
crates/topos-metrics/src/lib.rs 43.33% <58.82%> (+33.33%) ⬆️
crates/topos-tce/src/app_context/protocol.rs 75.00% <75.00%> (+0.88%) ⬆️
crates/topos-metrics/src/api.rs 100.00% <100.00%> (ø)
crates/topos-tce-api/src/grpc/mod.rs 57.40% <100.00%> (+0.39%) ⬆️
crates/topos-tce/src/app_context.rs 88.67% <100.00%> (+0.21%) ⬆️
crates/topos-tce/src/app_context/api.rs 59.57% <100.00%> (+1.33%) ⬆️

@hadjiszs hadjiszs merged commit de9c221 into main Aug 3, 2023
21 checks passed
@hadjiszs hadjiszs deleted the feat/TP-647 branch August 3, 2023 21:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants