chore: deprecate core (#439)

* chore: remove core dependency from midi

* chore: remove core dependency in key

* feat: cleanup chord-type dependencies

* chore: update mode dependencies

* chore: cleanup dependencies

* chore: update dependencies

.changeset/afraid-buttons-obey.md

@@ -0,0 +1,31 @@
+---
+"@tonaljs/roman-numeral": patch
+"@tonaljs/chord-detect": patch
+"@tonaljs/progression": patch
+"@tonaljs/chord-type": patch
+"@tonaljs/scale-type": patch
+"@tonaljs/pcset": patch
+"@tonaljs/range": patch
+"@tonaljs/scale": patch
+"tonal": patch
+"@tonaljs/midi": patch
+"@tonaljs/mode": patch
+"@tonaljs/note": patch
+"@tonaljs/key": patch
+---
+
+#### `default` export is deprecated for @tonaljs modules
+
+Using default exports for single packages are deprecated, so instead of:
+
+```js
+import Note from "@tonaljs/note";
+```
+
+You should do this:
+
+```js
+import * as Note from "@tonaljs/note";
+```
+
+The same for all modules.

.changeset/curly-adults-move.md

@@ -13,17 +13,3 @@ Now you can do:
 import { Note } from "tonal";
 Note.distance("c4", "e7"); // => "24M"
 ```
-
-#### Note `default` export is deprecated
-
-Using default exports for single packages are discouraged. For `note` module is now deprecated, so instead of:
-
-```js
-import Note from "@tonaljs/note";
-```
-
-You should do this:
-
-```js
-import * as Note from "@tonaljs/note";
-```

package.json

@@ -47,23 +47,24 @@
     "testEnvironment": "node"
   },
   "devDependencies": {
-    "@changesets/cli": "^2.26.1",
+    "@changesets/cli": "^2.27.7",
     "@types/jest": "^29.5.2",
     "@types/node": "^20.10.1",
     "@typescript-eslint/eslint-plugin": "^7.0.1",
     "@typescript-eslint/parser": "^7.0.1",
-    "esbuild": "^0.20.0",
+    "esbuild": "^0.23.0",
     "eslint": "^8.54.0",
     "jest": "^29.5.0",
     "jest-config": "^29.5.0",
     "lint-staged": "^15.1.0",
     "lodash": "^4.17.15",
     "prettier": "^3.1.0",
     "ts-jest": "^29.1.0",
-    "tsup": "^8.0.0",
-    "turbo": "^1.10.3",
+    "tsup": "^8.2.2",
+    "turbo": "^2.0.0",
     "typedoc": "^0.26.5",
     "typedoc-plugin-markdown": "^4.2.2",
-    "typescript": "^5.2.2"
-  }
+    "typescript": "^5.5.4"
+  },
+  "packageManager": "[email protected]"
 }

packages/chord-detect/index.ts

@@ -1,6 +1,6 @@
 import { all, ChordType } from "@tonaljs/chord-type";
-import { note } from "@tonaljs/core";
 import { modes } from "@tonaljs/pcset";
+import { note } from "@tonaljs/pitch-note";
 
 interface FoundChord {
   readonly weight: number;
@@ -124,4 +124,5 @@ function findMatches(
   return found;
 }
 
+/** @deprecated */
 export default { detect };

packages/chord-detect/package.json

@@ -6,7 +6,8 @@
     "chord-detect",
     "music",
     "theory",
-    "tonal"
+    "tonal",
+    "music-theory"
   ],
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -16,7 +17,7 @@
   "types": "dist/index.d.ts",
   "dependencies": {
     "@tonaljs/chord-type": "5.0.5",
-    "@tonaljs/core": "5.0.0",
+    "@tonaljs/pitch-note": "6.0.0",
     "@tonaljs/pcset": "4.9.2"
   },
   "author": "[email protected]",

packages/chord-type/index.ts

@@ -1,4 +1,3 @@
-import { deprecate } from "@tonaljs/core";
 import {
   EmptyPcset,
   get as pcset,
@@ -44,7 +43,8 @@ export function get(type: ChordTypeName): ChordType {
   return index[type] || NoChordType;
 }
 
-export const chordType = deprecate("ChordType.chordType", "ChordType.get", get);
+/** @deprecated */
+export const chordType = get;
 
 /**
  * Get all chord (long) names
@@ -74,7 +74,8 @@ export function all(): ChordType[] {
   return dictionary.slice();
 }
 
-export const entries = deprecate("ChordType.entries", "ChordType.all", all);
+/** @deprecated */
+export const entries = all;
 
 /**
  * Clear the dictionary
@@ -130,6 +131,7 @@ data.forEach(([ivls, fullName, names]: string[]) =>
 );
 dictionary.sort((a, b) => a.setNum - b.setNum);
 
+/** @deprecated */
 export default {
   names,
   symbols,

packages/chord-type/package.json

@@ -8,7 +8,7 @@
     "chords",
     "music",
     "theory",
-    "@tonaljs/core"
+    "music-theory"
   ],
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -17,7 +17,6 @@
   ],
   "types": "dist/index.d.ts",
   "dependencies": {
-    "@tonaljs/core": "5.0.0",
     "@tonaljs/pcset": "4.9.2"
   },
   "author": "[email protected]",

packages/key/index.ts

@@ -1,5 +1,5 @@
-import { accToAlt, altToAcc, note, transpose } from "@tonaljs/core";
-import { transposeFifths } from "@tonaljs/note";
+import { transpose, transposeFifths } from "@tonaljs/note";
+import { accToAlt, altToAcc, note } from "@tonaljs/pitch-note";
 import { get as roman } from "@tonaljs/roman-numeral";
 
 const Empty: readonly string[] = Object.freeze([] as string[]);
@@ -219,4 +219,5 @@ export function majorTonicFromKeySignature(
   return null;
 }
 
+/** @deprecated */
 export default { majorKey, majorTonicFromKeySignature, minorKey };

packages/key/package.json

@@ -6,7 +6,7 @@
     "key",
     "music",
     "theory",
-    "@tonaljs/core"
+    "music-theory"
   ],
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -15,7 +15,7 @@
   ],
   "types": "dist/index.d.ts",
   "dependencies": {
-    "@tonaljs/core": "5.0.0",
+    "@tonaljs/pitch-note": "6.0.0",
     "@tonaljs/note": "4.10.3",
     "@tonaljs/roman-numeral": "4.8.3"
   },

packages/midi/index.ts

@@ -1,4 +1,4 @@
-import { NoteName, note as props } from "@tonaljs/core";
+import { NoteName, note as props } from "@tonaljs/pitch-note";
 
 type Midi = number;
 
@@ -158,6 +158,7 @@ export function pcsetDegrees(notes: number[] | string, tonic: number) {
   };
 }
 
+/** @deprecated */
 export default {
   chroma,
   freqToMidi,

packages/midi/package.json

@@ -7,7 +7,7 @@
     "midi",
     "music",
     "theory",
-    "@tonaljs/core"
+    "tonal"
   ],
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -16,7 +16,7 @@
   ],
   "types": "dist/index.d.ts",
   "dependencies": {
-    "@tonaljs/core": "5.0.0"
+    "@tonaljs/pitch-note": "6.0.0"
   },
   "author": "[email protected]",
   "license": "MIT",

packages/mode/index.ts

@@ -1,7 +1,8 @@
 import { rotate } from "@tonaljs/collection";
-import { deprecate, NamedPitch, NoteName, transpose } from "@tonaljs/core";
 import { simplify, transposeFifths } from "@tonaljs/interval";
 import { EmptyPcset, Pcset } from "@tonaljs/pcset";
+import { transpose } from "@tonaljs/pitch-distance";
+import { NoteName } from "@tonaljs/pitch-note";
 import { get as getType } from "@tonaljs/scale-type";
 
 const MODES = [
@@ -44,7 +45,7 @@ modes.forEach((mode) => {
   });
 });
 
-type ModeLiteral = string | NamedPitch;
+type ModeLiteral = string | { name: string };
 
 /**
  * Get a Mode by it's name
@@ -73,15 +74,18 @@ export function get(name: ModeLiteral): Mode {
       : NoMode;
 }
 
-export const mode = deprecate("Mode.mode", "Mode.get", get);
+/** @deprecated */
+export const mode = get;
 
 /**
  * Get a list of all modes
  */
 export function all() {
   return modes.slice();
 }
-export const entries = deprecate("Mode.mode", "Mode.all", all);
+
+/** @deprecated */
+export const entries = all;
 
 /**
  * Get a list of all mode names

packages/mode/package.json

@@ -6,7 +6,7 @@
     "mode",
     "music",
     "theory",
-    "@tonaljs/core"
+    "music-theory"
   ],
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -16,7 +16,8 @@
   "types": "dist/index.d.ts",
   "dependencies": {
     "@tonaljs/collection": "4.8.1",
-    "@tonaljs/core": "5.0.0",
+    "@tonaljs/pitch-note": "6.0.0",
+    "@tonaljs/pitch-distance": "5.0.3",
     "@tonaljs/interval": "5.0.0",
     "@tonaljs/pcset": "4.9.2",
     "@tonaljs/scale-type": "4.8.5"

packages/note/package.json

@@ -6,7 +6,7 @@
     "note",
     "music",
     "theory",
-    "@tonaljs/core"
+    "music-theory"
   ],
   "main": "dist/index.js",
   "module": "dist/index.mjs",

packages/pcset/index.ts

@@ -1,15 +1,8 @@
 import { compact, range, rotate } from "@tonaljs/collection";
-import {
-  Interval,
-  IntervalName,
-  NotFound,
-  Note,
-  NoteName,
-  deprecate,
-  interval,
-  note,
-  transpose,
-} from "@tonaljs/core";
+import { NotFound } from "@tonaljs/pitch";
+import { transpose } from "@tonaljs/pitch-distance";
+import { Interval, IntervalName, interval } from "@tonaljs/pitch-interval";
+import { Note, NoteName, note } from "@tonaljs/pitch-note";
 
 /**
  * The properties of a pitch class set
@@ -97,11 +90,10 @@ export function get(src: Set): Pcset {
 }
 
 /**
- * Use Pcset.properties
- * @function
+ * @use Pcset.get
  * @deprecated
  */
-export const pcset = deprecate("Pcset.pcset", "Pcset.get", get);
+export const pcset = get;
 
 /**
  * Get pitch class set chroma
@@ -117,15 +109,15 @@ export const chroma = (set: Set) => get(set).chroma;
  * @example
  * Pcset.intervals(["c", "d", "e"]); //=>
  */
-const intervals = (set: Set) => get(set).intervals;
+export const intervals = (set: Set) => get(set).intervals;
 
 /**
  * Get pitch class set number
  * @function
  * @example
  * Pcset.num(["c", "d", "e"]); //=> 2192
  */
-const num = (set: Set) => get(set).setNum;
+export const num = (set: Set) => get(set).setNum;
 
 const IVLS = [
   "1P",
@@ -143,13 +135,13 @@ const IVLS = [
 ];
 
 /**
- * @private
  * Get the intervals of a pcset *starting from C*
+ * @private
  * @param {Set} set - the pitch class set
  * @return {IntervalName[]} an array of interval names or an empty array
  * if not a valid pitch class set
  */
-export function chromaToIntervals(chroma: PcsetChroma): IntervalName[] {
+function chromaToIntervals(chroma: PcsetChroma): IntervalName[] {
   const intervals = [];
   for (let i = 0; i < 12; i++) {
     // tslint:disable-next-line:curly
@@ -201,7 +193,7 @@ export function modes(set: Set, normalize = true): PcsetChroma[] {
 }
 
 /**
- * Test if two pitch class sets are numentical
+ * Test if two pitch class sets are equal
  *
  * @param {Array|string} set1 - one of the pitch class sets
  * @param {Array|string} set2 - the other pitch class set
@@ -303,6 +295,7 @@ export function filter(set: Set) {
   };
 }
 
+/** @deprecated */
 export default {
   get,
   chroma,