Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow initialize google places SDK from javascript #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GregoryNative
Copy link

I found this feature useful for me. Let me know if I need to add something else here.

@GregoryNative
Copy link
Author

There are should be added some notes as it will brake Android after migration

@rauchp
Copy link

rauchp commented Jan 20, 2020

This is a great improvement. It should really be merged onto master at some point.

@tolu360
Copy link
Owner

tolu360 commented Jun 15, 2020

Hi @GregoryNative, this looks interesting, I have thought about this route too. I am sorry I have been away and just looking at this. I am working on releasing a v4, a week from now, at the latest. However, do you think the keys would be more secure in Js? Feel feel to chime in again with your replies to this though. Thank you for your contributions all the same.

@GregoryNative
Copy link
Author

GregoryNative commented Jun 15, 2020

Hi, @tolu360 that's fine as we have react-native-config to use with.

@tolu360
Copy link
Owner

tolu360 commented Jun 15, 2020

So @GregoryNative have you had any issues with your keys in Manifest files? I am leaning towards going with you as some users have reported Google Play Store flagging the current location in Gradle properties as less secure as well.

@GregoryNative
Copy link
Author

As far as I know it's fine. I am not on project with usage of this lib anymore. But as least several months ago there were no issues @tolu360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants