Fix double white in VOG names #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blutze
changed the title
|
Yeah, I don't really get into contact with firearms stuff in German at all. And having only some keys translated is weird, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged, this PR will:
Add German translation to the Core stringtableNot sure how far I wanna go with this. 99.9% of my contact with military stuff is through pop culture in English, the magazine name structure doesn't lend itself to short phrasing ("Sandfarbenes PMAG" vs "PMAG (Sand)", and I've gotten to a point I already touched in a separate PR and I don't know how that'll work out merging in the GitHub webclient.
Might actually just revert the German stuff entirely.