Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stringtable duplicates & other translation errors #156

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Stringtable duplicates & other translation errors #156

wants to merge 10 commits into from

Conversation

Blutze
Copy link
Contributor

@Blutze Blutze commented May 5, 2019 •
edited
Loading

Lets try this draft feature.

This PR will:

  • Rename and reapply translation key for hlc_lmg_minimipara_long_railed, fixes a duplicate
  • Add and apply translation key for the tan SAW frontgrip
  • Fix some line endings in SAW config.cpp (webclient couldn't keep its grubby paws off of that)
  • Rename translation key for "LSW" FALs, fixes a duplicate
  • Apply battle rifle translation to FAL 50.00 description
  • Add spaces between colon and text on caliber line of ACR and AWP rifle and muzzle device descriptions
  • Fix Czech AWC rifle description (was unfinished French text, now back to English text)
  • Fix magazine descriptions for 100/200 round SOST M60 mags; closes 7.62 belt misnaming #153.
  • Removed translation duplicates from P226 stringtable (ammo short descriptions are in Core, MP5 handguard is in MP5s)

To Do in this PR:

  • Remove MG3 translation duplicates from Minigun stringtable. This is pending me wrapping my head around why the 500 round magazine description was changed (was that intentional, or just copypaste?).

To Do later:

  • Fix AWP and ACR rifle description key usages, as per ticket 139. Requires the config.cpp files for those packs to be committed; will allow to close it.

Blutze added 9 commits May 3, 2019 18:44
@Blutze
Update P226 stringtable
a4ef5d5 
- Removed errant STR_NIA_Slimline_DESC duplicate
- Removed ammo type short description duplicates
@Blutze
Update SAW stringtable
45384f9 
- Fixed STR_NIA_lmg_minimipara_long_railed keyname
- Added translation key for tan SAW frontgrip
@Blutze
Update FAL stringtable
991e9bb 
- Renamed key for generic FAL LSW
@Blutze
Update FAL config.cpp
9701ce8 
- Fixed FAL 50.00 description to use translation
@Blutze
Update AWM stringtable
656d715 
- Added missing space in gun descriptions
- Restored Czech AWC description after a French invasion
@Blutze
Update ACR stringtable
6ff0aec 
- Added missing spaces in rifle and flash hider descriptions
@Blutze
Update Core stringtable
8f62e79 
- Fixed 100/200 round SOST belt displaynames
@Blutze
Update SAW config
9374f9e 
- Made hlc_lmg_minimipara_long_railed used correct translation key
- Made tan SAW frontgrip use new tan translation key
- Webclient automatically fixed mixed line endings to windows; L44-L49 are functionally unchanged
@Blutze
Update Minigun stringtable
58696ed 
- Removed errant translation key duplicates (~20 belt descriptions copypasted from MG3)
@Blutze
Copy link
Contributor Author

Blutze commented May 8, 2019

Screw that. It probably never did the "two rounds per round" thing. Minigun done.

@Blutze Blutze marked this pull request as ready for review May 8, 2019 06:29
@Blutze Blutze mentioned this pull request Aug 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7.62 belt misnaming
1 participant
@Blutze