fix: error thrown on expect()

tlvince · Jul 28, 2017 · a1c01e2 · a1c01e2
1 parent 80bb8cd
commit a1c01e2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/rules/prefer-jasmine-matcher.js b/lib/rules/prefer-jasmine-matcher.js
@@ -17,7 +17,7 @@ module.exports = function (context) {
         suiteDepth++
       } else if (node.callee.name === 'expect' && suiteDepth > 0) {
         var expectNode = node.arguments && node.arguments[0]
-        if (expectNode.type === 'BinaryExpression' && operators.indexOf(expectNode.operator) > -1) {
+        if (expectNode && expectNode.type === 'BinaryExpression' && operators.indexOf(expectNode.operator) > -1) {
           context.report({
             message: 'Prefer jasmine matcher instead of comparison',
             node

diff --git a/test/rules/prefer-jasmine-matcher.js b/test/rules/prefer-jasmine-matcher.js
@@ -38,6 +38,14 @@ eslintTester.run('prefer jasmine matcher', rule, {
       '  expect(a instanceof String).toBe(true)',
       ' });',
       '});'
+    ]),
+    // issue #136
+    linesToCode([
+      'describe("", function() {',
+      ' it("", function(){',
+      '  expect()',
+      ' });',
+      '});'
     ])
   ],
   invalid: [