Fix pooled_hazard_task bug
#333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pooled hazards task does not work as intended (or errors) when using tasks that have non-null row_index internal variables. This occurs because when passing in a new dataset to next_in_chain, it does not reset the internal row_index variable. This makes using CV learners that utilize pooled hazards tasks internally (e.g. Lrnr_cv$new(Lrnr_pooled_hazards$new())) break down. For tmle3 survival, the pooled hazards task was created externally as the main task, so the hazard estimation with CV was not impacted by this bug. It might also be worth changing sl3_Task so that row_index is reset when passing in a new dataset. Or, maybe we should just not allow datasets to be passed in through next_in_chain.
Cheap fix for Lrnr_hal to work with latest version of hal9001/devel
Fixed type
|
I think the issue is that squash_hal_fit is pretty broken in the master version of hal9001. I will work on getting the checks to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pooled hazards task does not work as intended (or errors) when using tasks that have non-null row_index internal variables. This occurs because when passing in a new dataset to next_in_chain, it does not reset the internal row_index variable. This makes using CV learners that utilize pooled hazards tasks internally (e.g. Lrnr_cv$new(Lrnr_pooled_hazards$new())) break down. For tmle3 survival, the pooled hazards task was created externally as the main task, so the hazard estimation with CV was not impacted by this bug.
It might also be worth changing sl3_Task so that row_index is reset when passing in a new dataset. Or, maybe we should just not allow datasets to be passed in through next_in_chain.
Also, changed Lrnr_hal9001 so that all params are passed into fit_hal.
Also, added squash option for Lrnr_hal9001 to reduce computation time.